combined and sequential order and return numbers

[mayo]

I haven't looked deep into the code yet.  I wanted to ask some of you seasoned OFBiz developers first.  I am in a situation where I need to have the return numbers pull from the order's sequence pool so that both order and return numbers are sequential without skipping numbers.

I looked around the settings but I couldn't find one.  Before I waste time developing and testing this, does anyone know that this couldn't work without major changes or will it be a simple code change to the logic that gets return numbers?

I am using OFBiz 4.0.

[David E Jones-3]

The answer you seek is in the PartyAcctgPreference entity. It sounds  
like you're comfortable with code, so the fastest way (well, IMO) is  
to search across the project for that and you'll find the entity  
definition, demo data, UI for changing it, and even code that uses the  
settings (if your curiosity extends to all of that).

Short answer is yes, most of that is implemented.

-David


On Mar 17, 2009, at 2:36 PM, mayo wrote:

>
> I haven't looked deep into the code yet.  I wanted to ask some of you
> seasoned OFBiz developers first.  I am in a situation where I need  
> to have
> the return numbers pull from the order's sequence pool so that both  
> order
> and return numbers are sequential without skipping numbers.
>
> I looked around the settings but I couldn't find one.  Before I  
> waste time
> developing and testing this, does anyone know that this couldn't work
> without major changes or will it be a simple code change to the  
> logic that
> gets return numbers?
>
> I am using OFBiz 4.0.
> --
> View this message in context: http://www.nabble.com/combined-and-sequential-order-and-return-numbers-tp22567307p22567307.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>

[mayo]

Hey David.  Thanks so much for the quick response and the pointer.  I just want to verify with you what I am seeing.  In PartyAcctgPreference there is a setting to have the returns continue the invoice number.  For my situation, I would just have to follow the same logic, add a acctg setting, and program OFbiz to do the same for the order number?

Thanks again.

mayo wrote

I haven't looked deep into the code yet.  I wanted to ask some of you seasoned OFBiz developers first.  I am in a situation where I need to have the return numbers pull from the order's sequence pool so that both order and return numbers are sequential without skipping numbers.

I looked around the settings but I couldn't find one.  Before I waste time developing and testing this, does anyone know that this couldn't work without major changes or will it be a simple code change to the logic that gets return numbers?

I am using OFBiz 4.0.

[mayo]

OFBiz is great.  A few lines of code and returns are now pulling from the order number sequence.

For the solution I added a useOrderIdForReturns indicator, modified the admin form, and programmed a return to look at useOrderIdForReturns and call getNextOrderId if needed.

Thanks again David for the pointer.  You saved me a bunch of time.

[David E Jones-3]

On Mar 19, 2009, at 3:58 PM, mayo wrote:

> OFBiz is great.  A few lines of code and returns are now pulling  
> from the
> order number sequence.
>
> For the solution I added a useOrderIdForReturns indicator, modified  
> the
> admin form, and programmed a return to look at useOrderIdForReturns  
> and call
> getNextOrderId if needed.
>
> Thanks again David for the pointer.  You saved me a bunch of time.

That's great, I'm glad it worked out for you. I apologize for not  
getting to your follow up email faster... it's a mixed blessing but  
there has just been a ton of activity lately!

Is this something you would be willing to share? To do this just  
create a Jira issue and attach your patch (if you don't think it's  
perfect, feel free to attach it anyway and just mention that you want  
to sure but you're not sure if it's really ready to be committed into  
the project). Based on what you've described the approach looks great  
though.

-David

[mayo]

Don't mind sharing at all.  For reference - OFBIZ-2247

David E Jones-3 wrote

On Mar 19, 2009, at 3:58 PM, mayo wrote:

> OFBiz is great.  A few lines of code and returns are now pulling  
> from the
> order number sequence.
>
> For the solution I added a useOrderIdForReturns indicator, modified  
> the
> admin form, and programmed a return to look at useOrderIdForReturns  
> and call
> getNextOrderId if needed.
>
> Thanks again David for the pointer.  You saved me a bunch of time.

That's great, I'm glad it worked out for you. I apologize for not  
getting to your follow up email faster... it's a mixed blessing but  
there has just been a ton of activity lately!

Is this something you would be willing to share? To do this just  
create a Jira issue and attach your patch (if you don't think it's  
perfect, feel free to attach it anyway and just mention that you want  
to sure but you're not sure if it's really ready to be committed into  
the project). Based on what you've described the approach looks great  
though.

-David