commons-dbcp-1.3-20091111-r829616.jar or commons-dbcp.jar ?

[Jacques Le Roux]

Hi,

Following https://issues.apache.org/jira/browse/OFBIZ-2599 and https://issues.apache.org/jira/browse/DBCP-294
I have build both
the last DBCP available revision (commons-dbcp.jar)
and
commons-dbcp-1.3-20091111-r829616.jar

Should we continue to follow the previous way or should we not include the lastest ? As some fixes have been added between I'd
prefer the lastest.
There have been the following changes between

________________________________________________________________________________________
Revision: 834702
Author: markt
Date: 00:01:56, mercredi 11 novembre 2009
Message:
Fix DBCP-303. Patch provided by Dave Oxley.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java
Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml

Revision: 834346
Author: psteitz
Date: 06:05:54, mardi 10 novembre 2009
Message:
Made inner class static.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/jocl/JOCLContentHandler.java

Revision: 834335
Author: psteitz
Date: 05:19:12, mardi 10 novembre 2009
Message:
Added test case verifying that prepared statement pool acts as LRU cache.
----
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java

Revision: 832634
Author: psteitz
Date: 01:31:50, mercredi 4 novembre 2009
Message:
Made PoolGuardConnectionWrapper static, eliminated possible NPE in toString.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java

Revision: 831723
Author: psteitz
Date: 19:35:35, dimanche 1 novembre 2009
Message:
Added findbugs exclude filter.
----
Added : /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
Modified : /commons/proper/dbcp/trunk/pom.xml

Revision: 831707
Author: psteitz
Date: 18:02:29, dimanche 1 novembre 2009
Message:
Avoid possible NPE on toString().
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDataSource.java

Revision: 831703
Author: psteitz
Date: 17:52:19, dimanche 1 novembre 2009
Message:
Made prepared statement key inner class static.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java

Revision: 831690
Author: psteitz
Date: 16:51:29, dimanche 1 novembre 2009
Message:
Added null statement key field check in makeObject.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java

Revision: 831576
Author: psteitz
Date: 19:13:14, samedi 31 octobre 2009
Message:
Removed incorrectly advertised exception. JIRA: DBCP-302.  Thanks to Sebastian Bazley.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/jocl/JOCLContentHandler.java
Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml

Revision: 830174
Author: markt
Date: 14:30:50, mardi 27 octobre 2009
Message:
Add a test case for DBCP-265
----
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java
Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingDatabaseMetaData.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterConnection.java
Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDatabaseMetaData.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterResultSet.java

Revision: 830170
Author: markt
Date: 14:28:48, mardi 27 octobre 2009
Message:
Complete the fix for DBCP-265
I noticed this gap when writing the Javadoc for DelegatingDatabaseMetaData
Test case to follow
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java

Revision: 830162
Author: markt
Date: 14:18:54, mardi 27 octobre 2009
Message:
Add some JavaDoc
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java

Revision: 830136
Author: sebb
Date: 12:28:05, mardi 27 octobre 2009
Message:
Null checks
----
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java

Revision: 830135
Author: sebb
Date: 12:25:13, mardi 27 octobre 2009
Message:
assertTrue(var != null) => assertNotNull(var)
- simplifies code
- avoids later warnings of possible NPE
----
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/cpdsadapter/TestDriverAdapterCPDS.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSourceInTx.java

Revision: 830130
Author: sebb
Date: 12:03:06, mardi 27 octobre 2009
Message:
Add AL header
----
Modified : /commons/proper/dbcp/trunk/doap_dbcp.rdf

Revision: 830126
Author: markt
Date: 11:45:48, mardi 27 octobre 2009
Message:
Fix line endings and add missing svn properties
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/PoolableManagedConnection.java
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/PoolableManagedConnectionFactory.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/cpdsadapter/TestDriverAdapterCPDS.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestCPDSConnectionFactory.java

Revision: 830125
Author: markt
Date: 11:36:25, mardi 27 octobre 2009
Message:
Fix various Checkstyle/Eclipse warnings in the test cases including
- remove unused imports
- remove unused local variables
- mark methods as deprecated if they override deprecated methods
- avoid auto-boxing

All unit tess still pass
----
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDriverManagerConnectionFactory.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPooling.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterCallableStatement.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/cpdsadapter/TestDriverAdapterCPDS.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/PooledConnectionProxy.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestCPDSConnectionFactory.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestInstanceKeyDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestBasicManagedDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/jocl/TestAll.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/jocl/TestJOCLContentHandler.java

Revision: 830110
Author: markt
Date: 10:55:10, mardi 27 octobre 2009
Message:
Remove unused import
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java

Revision: 829661
Author: markt
Date: 22:41:41, dimanche 25 octobre 2009
Message:
Add recent fixes.
----
Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml

Revision: 829659
Author: markt
Date: 22:37:10, dimanche 25 octobre 2009
Message:
Fix DBCP-203. Provide an option to specify the class loader to be used to load the JDBC driver for a BasicDataSource.
Based on a patch suggested by Mark Grand.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java

Revision: 829653
Author: markt
Date: 22:16:18, dimanche 25 octobre 2009
Message:
Extend fix for DBCP-8 to PerUserPoolDataSource
The fix is a little ugly to maintain binary compatibility in PoolKey - I really wanted to add password as a separate field
Unit tests all pass with fix applied
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/PoolKey.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java

Revision: 829642
Author: psteitz
Date: 21:36:14, dimanche 25 octobre 2009
Message:
Improved thread-safety.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestBasicManagedDataSource.java

Revision: 829623
Author: psteitz
Date: 19:19:37, dimanche 25 octobre 2009
Message:
Made XADataSource configurable in BasicManagedDataSource.
JIRA: DBCP-289
Reported and patched by Marc Kannegießer.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml

Revision: 829618
Author: psteitz
Date: 17:57:18, dimanche 25 octobre 2009
Message:
Removed deprecated exception class prior to first release of BasicManagedDataSourc.
----
Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java


Thanks and sorry for the long post

Jacques

[Jacopo Cappellato-4]

Jacques,

this is an interesting thread, but I am a bit confused.
In the log of changes I don't see a reference to DBCP-294.
Also, is there a schedule for the release of the next stable release  
of DBCP? And what exactly are you suggesting to do?

Thanks,

Jacopo


On Nov 11, 2009, at 11:17 PM, Jacques Le Roux wrote:

> Hi,
>
> Following https://issues.apache.org/jira/browse/OFBIZ-2599 and https://issues.apache.org/jira/browse/DBCP-294
> I have build both
> the last DBCP available revision (commons-dbcp.jar)
> and
> commons-dbcp-1.3-20091111-r829616.jar
>
> Should we continue to follow the previous way or should we not  
> include the lastest ? As some fixes have been added between I'd  
> prefer the lastest.
> There have been the following changes between
>
> ________________________________________________________________________________________
> Revision: 834702
> Author: markt
> Date: 00:01:56, mercredi 11 novembre 2009
> Message:
> Fix DBCP-303. Patch provided by Dave Oxley.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/cpdsadapter/PooledConnectionImpl.java
> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>
> Revision: 834346
> Author: psteitz
> Date: 06:05:54, mardi 10 novembre 2009
> Message:
> Made inner class static.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> jocl/JOCLContentHandler.java
>
> Revision: 834335
> Author: psteitz
> Date: 05:19:12, mardi 10 novembre 2009
> Message:
> Added test case verifying that prepared statement pool acts as LRU  
> cache.
> ----
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestPStmtPoolingBasicDataSource.java
>
> Revision: 832634
> Author: psteitz
> Date: 01:31:50, mercredi 4 novembre 2009
> Message:
> Made PoolGuardConnectionWrapper static, eliminated possible NPE in  
> toString.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/PoolingDriver.java
>
> Revision: 831723
> Author: psteitz
> Date: 19:35:35, dimanche 1 novembre 2009
> Message:
> Added findbugs exclude filter.
> ----
> Added : /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
> Modified : /commons/proper/dbcp/trunk/pom.xml
>
> Revision: 831707
> Author: psteitz
> Date: 18:02:29, dimanche 1 novembre 2009
> Message:
> Avoid possible NPE on toString().
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/PoolingDataSource.java
>
> Revision: 831703
> Author: psteitz
> Date: 17:52:19, dimanche 1 novembre 2009
> Message:
> Made prepared statement key inner class static.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/PoolingConnection.java
>
> Revision: 831690
> Author: psteitz
> Date: 16:51:29, dimanche 1 novembre 2009
> Message:
> Added null statement key field check in makeObject.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/PoolingConnection.java
>
> Revision: 831576
> Author: psteitz
> Date: 19:13:14, samedi 31 octobre 2009
> Message:
> Removed incorrectly advertised exception. JIRA: DBCP-302.  Thanks to  
> Sebastian Bazley.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> jocl/JOCLContentHandler.java
> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>
> Revision: 830174
> Author: markt
> Date: 14:30:50, mardi 27 octobre 2009
> Message:
> Add a test case for DBCP-265
> ----
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestAll.java
> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/
> TestDelegatingDatabaseMetaData.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TesterConnection.java
> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/
> TesterDatabaseMetaData.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TesterResultSet.java
>
> Revision: 830170
> Author: markt
> Date: 14:28:48, mardi 27 octobre 2009
> Message:
> Complete the fix for DBCP-265
> I noticed this gap when writing the Javadoc for  
> DelegatingDatabaseMetaData
> Test case to follow
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/DelegatingConnection.java
>
> Revision: 830162
> Author: markt
> Date: 14:18:54, mardi 27 octobre 2009
> Message:
> Add some JavaDoc
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/DelegatingDatabaseMetaData.java
>
> Revision: 830136
> Author: sebb
> Date: 12:28:05, mardi 27 octobre 2009
> Message:
> Null checks
> ----
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestConnectionPool.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestPoolableConnection.java
>
> Revision: 830135
> Author: sebb
> Date: 12:25:13, mardi 27 octobre 2009
> Message:
> assertTrue(var != null) => assertNotNull(var)
> - simplifies code
> - avoids later warnings of possible NPE
> ----
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestBasicDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestConnectionPool.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestPoolableConnection.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/cpdsadapter/TestDriverAdapterCPDS.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestPerUserPoolDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestSharedPoolDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/managed/TestManagedDataSourceInTx.java
>
> Revision: 830130
> Author: sebb
> Date: 12:03:06, mardi 27 octobre 2009
> Message:
> Add AL header
> ----
> Modified : /commons/proper/dbcp/trunk/doap_dbcp.rdf
>
> Revision: 830126
> Author: markt
> Date: 11:45:48, mardi 27 octobre 2009
> Message:
> Fix line endings and add missing svn properties
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/managed/PoolableManagedConnection.java
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/managed/PoolableManagedConnectionFactory.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/cpdsadapter/TestDriverAdapterCPDS.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestCPDSConnectionFactory.java
>
> Revision: 830125
> Author: markt
> Date: 11:36:25, mardi 27 octobre 2009
> Message:
> Fix various Checkstyle/Eclipse warnings in the test cases including
> - remove unused imports
> - remove unused local variables
> - mark methods as deprecated if they override deprecated methods
> - avoid auto-boxing
>
> All unit tess still pass
> ----
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestBasicDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestDriverManagerConnectionFactory.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestManual.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TestPStmtPooling.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/TesterCallableStatement.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/cpdsadapter/TestDriverAdapterCPDS.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/PooledConnectionProxy.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestCPDSConnectionFactory.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestInstanceKeyDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestPerUserPoolDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/managed/TestBasicManagedDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> jocl/TestAll.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> jocl/TestJOCLContentHandler.java
>
> Revision: 830110
> Author: markt
> Date: 10:55:10, mardi 27 octobre 2009
> Message:
> Remove unused import
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/datasources/KeyedCPDSConnectionFactory.java
>
> Revision: 829661
> Author: markt
> Date: 22:41:41, dimanche 25 octobre 2009
> Message:
> Add recent fixes.
> ----
> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>
> Revision: 829659
> Author: markt
> Date: 22:37:10, dimanche 25 octobre 2009
> Message:
> Fix DBCP-203. Provide an option to specify the class loader to be  
> used to load the JDBC driver for a BasicDataSource.
> Based on a patch suggested by Mark Grand.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/BasicDataSource.java
>
> Revision: 829653
> Author: markt
> Date: 22:16:18, dimanche 25 octobre 2009
> Message:
> Extend fix for DBCP-8 to PerUserPoolDataSource
> The fix is a little ugly to maintain binary compatibility in PoolKey  
> - I really wanted to add password as a separate field
> Unit tests all pass with fix applied
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/datasources/PerUserPoolDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/datasources/PoolKey.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/datasources/TestPerUserPoolDataSource.java
>
> Revision: 829642
> Author: psteitz
> Date: 21:36:14, dimanche 25 octobre 2009
> Message:
> Improved thread-safety.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/managed/BasicManagedDataSource.java
> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/
> dbcp/managed/TestBasicManagedDataSource.java
>
> Revision: 829623
> Author: psteitz
> Date: 19:19:37, dimanche 25 octobre 2009
> Message:
> Made XADataSource configurable in BasicManagedDataSource.
> JIRA: DBCP-289
> Reported and patched by Marc Kannegießer.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/managed/BasicManagedDataSource.java
> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>
> Revision: 829618
> Author: psteitz
> Date: 17:57:18, dimanche 25 octobre 2009
> Message:
> Removed deprecated exception class prior to first release of  
> BasicManagedDataSourc.
> ----
> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/
> dbcp/managed/BasicManagedDataSource.java
>
>
> Thanks and sorry for the long post
>
> Jacques

[Jacques Le Roux]

Jacopo,

The log is all just above DBCP-294 change (between it and yesterday). I did not find any scheduled stable release, but this one
surely fix a bug we still have (and some others I guess).
I suggest to replace ou current commons-dbcp-1.3....jar by the latest I have buid yesterday.
I used ant from Eclipse based on a Maven 2 repository. I will give them a patch for the ant build.properties.sample which is
currently based on Maven 1 and getting Maven 1 is a nightmare (Archiva, etc.)
So my question was  : do we prefer to replace ou current commons-dbcp-1.3....jar by commons-dbcp-1.3-20091025-r829616.jar (I wronly
wrote commons-dbcp-1.3-20091111-r829616.jar yesterday night) which includes DBCP-294
or should we not include the lasted build I did which is actually commons-dbcp-1.3-20091111-r834702.jar

Thanks

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Jacques,
>
> this is an interesting thread, but I am a bit confused.
> In the log of changes I don't see a reference to DBCP-294.
> Also, is there a schedule for the release of the next stable release  of DBCP? And what exactly are you suggesting to do?
>
> Thanks,
>
> Jacopo
>
>
> On Nov 11, 2009, at 11:17 PM, Jacques Le Roux wrote:
>
>> Hi,
>>
>> Following https://issues.apache.org/jira/browse/OFBIZ-2599 and https://issues.apache.org/jira/browse/DBCP-294
>> I have build both
>> the last DBCP available revision (commons-dbcp.jar)
>> and
>> commons-dbcp-1.3-20091111-r829616.jar
>>
>> Should we continue to follow the previous way or should we not  include the lastest ? As some fixes have been added between I'd
>> prefer the lastest.
>> There have been the following changes between
>>
>> ________________________________________________________________________________________
>> Revision: 834702
>> Author: markt
>> Date: 00:01:56, mercredi 11 novembre 2009
>> Message:
>> Fix DBCP-303. Patch provided by Dave Oxley.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/cpdsadapter/PooledConnectionImpl.java
>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>
>> Revision: 834346
>> Author: psteitz
>> Date: 06:05:54, mardi 10 novembre 2009
>> Message:
>> Made inner class static.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>>
>> Revision: 834335
>> Author: psteitz
>> Date: 05:19:12, mardi 10 novembre 2009
>> Message:
>> Added test case verifying that prepared statement pool acts as LRU  cache.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPoolingBasicDataSource.java
>>
>> Revision: 832634
>> Author: psteitz
>> Date: 01:31:50, mercredi 4 novembre 2009
>> Message:
>> Made PoolGuardConnectionWrapper static, eliminated possible NPE in  toString.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDriver.java
>>
>> Revision: 831723
>> Author: psteitz
>> Date: 19:35:35, dimanche 1 novembre 2009
>> Message:
>> Added findbugs exclude filter.
>> ----
>> Added : /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
>> Modified : /commons/proper/dbcp/trunk/pom.xml
>>
>> Revision: 831707
>> Author: psteitz
>> Date: 18:02:29, dimanche 1 novembre 2009
>> Message:
>> Avoid possible NPE on toString().
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDataSource.java
>>
>> Revision: 831703
>> Author: psteitz
>> Date: 17:52:19, dimanche 1 novembre 2009
>> Message:
>> Made prepared statement key inner class static.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>
>> Revision: 831690
>> Author: psteitz
>> Date: 16:51:29, dimanche 1 novembre 2009
>> Message:
>> Added null statement key field check in makeObject.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>
>> Revision: 831576
>> Author: psteitz
>> Date: 19:13:14, samedi 31 octobre 2009
>> Message:
>> Removed incorrectly advertised exception. JIRA: DBCP-302.  Thanks to  Sebastian Bazley.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>
>> Revision: 830174
>> Author: markt
>> Date: 14:30:50, mardi 27 octobre 2009
>> Message:
>> Add a test case for DBCP-265
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestAll.java
>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TestDelegatingDatabaseMetaData.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterConnection.java
>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TesterDatabaseMetaData.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterResultSet.java
>>
>> Revision: 830170
>> Author: markt
>> Date: 14:28:48, mardi 27 octobre 2009
>> Message:
>> Complete the fix for DBCP-265
>> I noticed this gap when writing the Javadoc for  DelegatingDatabaseMetaData
>> Test case to follow
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingConnection.java
>>
>> Revision: 830162
>> Author: markt
>> Date: 14:18:54, mardi 27 octobre 2009
>> Message:
>> Add some JavaDoc
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingDatabaseMetaData.java
>>
>> Revision: 830136
>> Author: sebb
>> Date: 12:28:05, mardi 27 octobre 2009
>> Message:
>> Null checks
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>>
>> Revision: 830135
>> Author: sebb
>> Date: 12:25:13, mardi 27 octobre 2009
>> Message:
>> assertTrue(var != null) => assertNotNull(var)
>> - simplifies code
>> - avoids later warnings of possible NPE
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestSharedPoolDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestManagedDataSourceInTx.java
>>
>> Revision: 830130
>> Author: sebb
>> Date: 12:03:06, mardi 27 octobre 2009
>> Message:
>> Add AL header
>> ----
>> Modified : /commons/proper/dbcp/trunk/doap_dbcp.rdf
>>
>> Revision: 830126
>> Author: markt
>> Date: 11:45:48, mardi 27 octobre 2009
>> Message:
>> Fix line endings and add missing svn properties
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnection.java
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnectionFactory.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>>
>> Revision: 830125
>> Author: markt
>> Date: 11:36:25, mardi 27 octobre 2009
>> Message:
>> Fix various Checkstyle/Eclipse warnings in the test cases including
>> - remove unused imports
>> - remove unused local variables
>> - mark methods as deprecated if they override deprecated methods
>> - avoid auto-boxing
>>
>> All unit tess still pass
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestDriverManagerConnectionFactory.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestManual.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPooling.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterCallableStatement.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/PooledConnectionProxy.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestInstanceKeyDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestAll.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestJOCLContentHandler.java
>>
>> Revision: 830110
>> Author: markt
>> Date: 10:55:10, mardi 27 octobre 2009
>> Message:
>> Remove unused import
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/KeyedCPDSConnectionFactory.java
>>
>> Revision: 829661
>> Author: markt
>> Date: 22:41:41, dimanche 25 octobre 2009
>> Message:
>> Add recent fixes.
>> ----
>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>
>> Revision: 829659
>> Author: markt
>> Date: 22:37:10, dimanche 25 octobre 2009
>> Message:
>> Fix DBCP-203. Provide an option to specify the class loader to be  used to load the JDBC driver for a BasicDataSource.
>> Based on a patch suggested by Mark Grand.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/BasicDataSource.java
>>
>> Revision: 829653
>> Author: markt
>> Date: 22:16:18, dimanche 25 octobre 2009
>> Message:
>> Extend fix for DBCP-8 to PerUserPoolDataSource
>> The fix is a little ugly to maintain binary compatibility in PoolKey  - I really wanted to add password as a separate field
>> Unit tests all pass with fix applied
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PerUserPoolDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PoolKey.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>
>> Revision: 829642
>> Author: psteitz
>> Date: 21:36:14, dimanche 25 octobre 2009
>> Message:
>> Improved thread-safety.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>>
>> Revision: 829623
>> Author: psteitz
>> Date: 19:19:37, dimanche 25 octobre 2009
>> Message:
>> Made XADataSource configurable in BasicManagedDataSource.
>> JIRA: DBCP-289
>> Reported and patched by Marc Kannegießer.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>
>> Revision: 829618
>> Author: psteitz
>> Date: 17:57:18, dimanche 25 octobre 2009
>> Message:
>> Removed deprecated exception class prior to first release of  BasicManagedDataSourc.
>> ----
>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>
>>
>> Thanks and sorry for the long post
>>
>> Jacques
>
>

[Jacopo Cappellato-4]

Jacques,

thanks for the further details.
I am still a bit confused about the options you presents for jar files (np I probably just need another coffee) but yes, I think it makes sense to replace the current jar (that is already a snapshot, if I am not wrong) with a newer snapshot that includes the fix contributed in DBCP-294.

Kind regards,

Jacopo

On Nov 12, 2009, at 9:32 AM, Jacques Le Roux wrote:

> Jacopo,
>
> The log is all just above DBCP-294 change (between it and yesterday). I did not find any scheduled stable release, but this one surely fix a bug we still have (and some others I guess).
> I suggest to replace ou current commons-dbcp-1.3....jar by the latest I have buid yesterday.
> I used ant from Eclipse based on a Maven 2 repository. I will give them a patch for the ant build.properties.sample which is currently based on Maven 1 and getting Maven 1 is a nightmare (Archiva, etc.)
> So my question was  : do we prefer to replace ou current commons-dbcp-1.3....jar by commons-dbcp-1.3-20091025-r829616.jar (I wronly wrote commons-dbcp-1.3-20091111-r829616.jar yesterday night) which includes DBCP-294
> or should we not include the lasted build I did which is actually commons-dbcp-1.3-20091111-r834702.jar
>
> Thanks
>
> Jacques
>
> From: "Jacopo Cappellato" <[hidden email]>
>> Jacques,
>>
>> this is an interesting thread, but I am a bit confused.
>> In the log of changes I don't see a reference to DBCP-294.
>> Also, is there a schedule for the release of the next stable release  of DBCP? And what exactly are you suggesting to do?
>>
>> Thanks,
>>
>> Jacopo
>>
>>
>> On Nov 11, 2009, at 11:17 PM, Jacques Le Roux wrote:
>>
>>> Hi,
>>>
>>> Following https://issues.apache.org/jira/browse/OFBIZ-2599 and https://issues.apache.org/jira/browse/DBCP-294
>>> I have build both
>>> the last DBCP available revision (commons-dbcp.jar)
>>> and
>>> commons-dbcp-1.3-20091111-r829616.jar
>>>
>>> Should we continue to follow the previous way or should we not  include the lastest ? As some fixes have been added between I'd prefer the lastest.
>>> There have been the following changes between
>>>
>>> ________________________________________________________________________________________
>>> Revision: 834702
>>> Author: markt
>>> Date: 00:01:56, mercredi 11 novembre 2009
>>> Message:
>>> Fix DBCP-303. Patch provided by Dave Oxley.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/cpdsadapter/PooledConnectionImpl.java
>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>
>>> Revision: 834346
>>> Author: psteitz
>>> Date: 06:05:54, mardi 10 novembre 2009
>>> Message:
>>> Made inner class static.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>>>
>>> Revision: 834335
>>> Author: psteitz
>>> Date: 05:19:12, mardi 10 novembre 2009
>>> Message:
>>> Added test case verifying that prepared statement pool acts as LRU  cache.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPoolingBasicDataSource.java
>>>
>>> Revision: 832634
>>> Author: psteitz
>>> Date: 01:31:50, mercredi 4 novembre 2009
>>> Message:
>>> Made PoolGuardConnectionWrapper static, eliminated possible NPE in  toString.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDriver.java
>>>
>>> Revision: 831723
>>> Author: psteitz
>>> Date: 19:35:35, dimanche 1 novembre 2009
>>> Message:
>>> Added findbugs exclude filter.
>>> ----
>>> Added : /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
>>> Modified : /commons/proper/dbcp/trunk/pom.xml
>>>
>>> Revision: 831707
>>> Author: psteitz
>>> Date: 18:02:29, dimanche 1 novembre 2009
>>> Message:
>>> Avoid possible NPE on toString().
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDataSource.java
>>>
>>> Revision: 831703
>>> Author: psteitz
>>> Date: 17:52:19, dimanche 1 novembre 2009
>>> Message:
>>> Made prepared statement key inner class static.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>>
>>> Revision: 831690
>>> Author: psteitz
>>> Date: 16:51:29, dimanche 1 novembre 2009
>>> Message:
>>> Added null statement key field check in makeObject.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>>
>>> Revision: 831576
>>> Author: psteitz
>>> Date: 19:13:14, samedi 31 octobre 2009
>>> Message:
>>> Removed incorrectly advertised exception. JIRA: DBCP-302.  Thanks to  Sebastian Bazley.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>
>>> Revision: 830174
>>> Author: markt
>>> Date: 14:30:50, mardi 27 octobre 2009
>>> Message:
>>> Add a test case for DBCP-265
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestAll.java
>>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TestDelegatingDatabaseMetaData.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterConnection.java
>>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TesterDatabaseMetaData.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterResultSet.java
>>>
>>> Revision: 830170
>>> Author: markt
>>> Date: 14:28:48, mardi 27 octobre 2009
>>> Message:
>>> Complete the fix for DBCP-265
>>> I noticed this gap when writing the Javadoc for  DelegatingDatabaseMetaData
>>> Test case to follow
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingConnection.java
>>>
>>> Revision: 830162
>>> Author: markt
>>> Date: 14:18:54, mardi 27 octobre 2009
>>> Message:
>>> Add some JavaDoc
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingDatabaseMetaData.java
>>>
>>> Revision: 830136
>>> Author: sebb
>>> Date: 12:28:05, mardi 27 octobre 2009
>>> Message:
>>> Null checks
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>>>
>>> Revision: 830135
>>> Author: sebb
>>> Date: 12:25:13, mardi 27 octobre 2009
>>> Message:
>>> assertTrue(var != null) => assertNotNull(var)
>>> - simplifies code
>>> - avoids later warnings of possible NPE
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestSharedPoolDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestManagedDataSourceInTx.java
>>>
>>> Revision: 830130
>>> Author: sebb
>>> Date: 12:03:06, mardi 27 octobre 2009
>>> Message:
>>> Add AL header
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/doap_dbcp.rdf
>>>
>>> Revision: 830126
>>> Author: markt
>>> Date: 11:45:48, mardi 27 octobre 2009
>>> Message:
>>> Fix line endings and add missing svn properties
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnection.java
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnectionFactory.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>>>
>>> Revision: 830125
>>> Author: markt
>>> Date: 11:36:25, mardi 27 octobre 2009
>>> Message:
>>> Fix various Checkstyle/Eclipse warnings in the test cases including
>>> - remove unused imports
>>> - remove unused local variables
>>> - mark methods as deprecated if they override deprecated methods
>>> - avoid auto-boxing
>>>
>>> All unit tess still pass
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestDriverManagerConnectionFactory.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestManual.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPooling.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterCallableStatement.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/PooledConnectionProxy.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestInstanceKeyDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestAll.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestJOCLContentHandler.java
>>>
>>> Revision: 830110
>>> Author: markt
>>> Date: 10:55:10, mardi 27 octobre 2009
>>> Message:
>>> Remove unused import
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/KeyedCPDSConnectionFactory.java
>>>
>>> Revision: 829661
>>> Author: markt
>>> Date: 22:41:41, dimanche 25 octobre 2009
>>> Message:
>>> Add recent fixes.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>
>>> Revision: 829659
>>> Author: markt
>>> Date: 22:37:10, dimanche 25 octobre 2009
>>> Message:
>>> Fix DBCP-203. Provide an option to specify the class loader to be  used to load the JDBC driver for a BasicDataSource.
>>> Based on a patch suggested by Mark Grand.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/BasicDataSource.java
>>>
>>> Revision: 829653
>>> Author: markt
>>> Date: 22:16:18, dimanche 25 octobre 2009
>>> Message:
>>> Extend fix for DBCP-8 to PerUserPoolDataSource
>>> The fix is a little ugly to maintain binary compatibility in PoolKey  - I really wanted to add password as a separate field
>>> Unit tests all pass with fix applied
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PerUserPoolDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PoolKey.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>>
>>> Revision: 829642
>>> Author: psteitz
>>> Date: 21:36:14, dimanche 25 octobre 2009
>>> Message:
>>> Improved thread-safety.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>>>
>>> Revision: 829623
>>> Author: psteitz
>>> Date: 19:19:37, dimanche 25 octobre 2009
>>> Message:
>>> Made XADataSource configurable in BasicManagedDataSource.
>>> JIRA: DBCP-289
>>> Reported and patched by Marc Kannegießer.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>
>>> Revision: 829618
>>> Author: psteitz
>>> Date: 17:57:18, dimanche 25 octobre 2009
>>> Message:
>>> Removed deprecated exception class prior to first release of  BasicManagedDataSourc.
>>> ----
>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>>
>>>
>>> Thanks and sorry for the long post
>>>
>>> Jacques
>>
>
>

[Jacques Le Roux]

Jacopo,

I gave up on coffee, and even tea, years ago... Only nerves ;o)
Yes it also a snapshot, I don't know who made it, you commited it.
I will update with latest as I don't see any reasons to choose one or another and both fix
https://issues.apache.org/jira/browse/OFBIZ-2599

Thanks

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Jacques,
>
> thanks for the further details.
> I am still a bit confused about the options you presents for jar files (np I probably just need another coffee) but yes, I think
> it makes sense to replace the current jar (that is already a snapshot, if I am not wrong) with a newer snapshot that includes the
> fix contributed in DBCP-294.
>
> Kind regards,
>
> Jacopo
>
> On Nov 12, 2009, at 9:32 AM, Jacques Le Roux wrote:
>
>> Jacopo,
>>
>> The log is all just above DBCP-294 change (between it and yesterday). I did not find any scheduled stable release, but this one
>> surely fix a bug we still have (and some others I guess).
>> I suggest to replace ou current commons-dbcp-1.3....jar by the latest I have buid yesterday.
>> I used ant from Eclipse based on a Maven 2 repository. I will give them a patch for the ant build.properties.sample which is
>> currently based on Maven 1 and getting Maven 1 is a nightmare (Archiva, etc.)
>> So my question was  : do we prefer to replace ou current commons-dbcp-1.3....jar by commons-dbcp-1.3-20091025-r829616.jar (I
>> wronly wrote commons-dbcp-1.3-20091111-r829616.jar yesterday night) which includes DBCP-294
>> or should we not include the lasted build I did which is actually commons-dbcp-1.3-20091111-r834702.jar
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Jacopo Cappellato" <[hidden email]>
>>> Jacques,
>>>
>>> this is an interesting thread, but I am a bit confused.
>>> In the log of changes I don't see a reference to DBCP-294.
>>> Also, is there a schedule for the release of the next stable release  of DBCP? And what exactly are you suggesting to do?
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>
>>>
>>> On Nov 11, 2009, at 11:17 PM, Jacques Le Roux wrote:
>>>
>>>> Hi,
>>>>
>>>> Following https://issues.apache.org/jira/browse/OFBIZ-2599 and https://issues.apache.org/jira/browse/DBCP-294
>>>> I have build both
>>>> the last DBCP available revision (commons-dbcp.jar)
>>>> and
>>>> commons-dbcp-1.3-20091111-r829616.jar
>>>>
>>>> Should we continue to follow the previous way or should we not  include the lastest ? As some fixes have been added between I'd
>>>> prefer the lastest.
>>>> There have been the following changes between
>>>>
>>>> ________________________________________________________________________________________
>>>> Revision: 834702
>>>> Author: markt
>>>> Date: 00:01:56, mercredi 11 novembre 2009
>>>> Message:
>>>> Fix DBCP-303. Patch provided by Dave Oxley.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/cpdsadapter/PooledConnectionImpl.java
>>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>>
>>>> Revision: 834346
>>>> Author: psteitz
>>>> Date: 06:05:54, mardi 10 novembre 2009
>>>> Message:
>>>> Made inner class static.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>>>>
>>>> Revision: 834335
>>>> Author: psteitz
>>>> Date: 05:19:12, mardi 10 novembre 2009
>>>> Message:
>>>> Added test case verifying that prepared statement pool acts as LRU  cache.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPoolingBasicDataSource.java
>>>>
>>>> Revision: 832634
>>>> Author: psteitz
>>>> Date: 01:31:50, mercredi 4 novembre 2009
>>>> Message:
>>>> Made PoolGuardConnectionWrapper static, eliminated possible NPE in  toString.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDriver.java
>>>>
>>>> Revision: 831723
>>>> Author: psteitz
>>>> Date: 19:35:35, dimanche 1 novembre 2009
>>>> Message:
>>>> Added findbugs exclude filter.
>>>> ----
>>>> Added : /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
>>>> Modified : /commons/proper/dbcp/trunk/pom.xml
>>>>
>>>> Revision: 831707
>>>> Author: psteitz
>>>> Date: 18:02:29, dimanche 1 novembre 2009
>>>> Message:
>>>> Avoid possible NPE on toString().
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingDataSource.java
>>>>
>>>> Revision: 831703
>>>> Author: psteitz
>>>> Date: 17:52:19, dimanche 1 novembre 2009
>>>> Message:
>>>> Made prepared statement key inner class static.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>>>
>>>> Revision: 831690
>>>> Author: psteitz
>>>> Date: 16:51:29, dimanche 1 novembre 2009
>>>> Message:
>>>> Added null statement key field check in makeObject.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/PoolingConnection.java
>>>>
>>>> Revision: 831576
>>>> Author: psteitz
>>>> Date: 19:13:14, samedi 31 octobre 2009
>>>> Message:
>>>> Removed incorrectly advertised exception. JIRA: DBCP-302.  Thanks to  Sebastian Bazley.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ jocl/JOCLContentHandler.java
>>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>>
>>>> Revision: 830174
>>>> Author: markt
>>>> Date: 14:30:50, mardi 27 octobre 2009
>>>> Message:
>>>> Add a test case for DBCP-265
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestAll.java
>>>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TestDelegatingDatabaseMetaData.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterConnection.java
>>>> Added : /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/ TesterDatabaseMetaData.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterResultSet.java
>>>>
>>>> Revision: 830170
>>>> Author: markt
>>>> Date: 14:28:48, mardi 27 octobre 2009
>>>> Message:
>>>> Complete the fix for DBCP-265
>>>> I noticed this gap when writing the Javadoc for  DelegatingDatabaseMetaData
>>>> Test case to follow
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingConnection.java
>>>>
>>>> Revision: 830162
>>>> Author: markt
>>>> Date: 14:18:54, mardi 27 octobre 2009
>>>> Message:
>>>> Add some JavaDoc
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/DelegatingDatabaseMetaData.java
>>>>
>>>> Revision: 830136
>>>> Author: sebb
>>>> Date: 12:28:05, mardi 27 octobre 2009
>>>> Message:
>>>> Null checks
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>>>>
>>>> Revision: 830135
>>>> Author: sebb
>>>> Date: 12:25:13, mardi 27 octobre 2009
>>>> Message:
>>>> assertTrue(var != null) => assertNotNull(var)
>>>> - simplifies code
>>>> - avoids later warnings of possible NPE
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestConnectionPool.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPoolableConnection.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestSharedPoolDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestManagedDataSourceInTx.java
>>>>
>>>> Revision: 830130
>>>> Author: sebb
>>>> Date: 12:03:06, mardi 27 octobre 2009
>>>> Message:
>>>> Add AL header
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/doap_dbcp.rdf
>>>>
>>>> Revision: 830126
>>>> Author: markt
>>>> Date: 11:45:48, mardi 27 octobre 2009
>>>> Message:
>>>> Fix line endings and add missing svn properties
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnection.java
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/PoolableManagedConnectionFactory.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>>>>
>>>> Revision: 830125
>>>> Author: markt
>>>> Date: 11:36:25, mardi 27 octobre 2009
>>>> Message:
>>>> Fix various Checkstyle/Eclipse warnings in the test cases including
>>>> - remove unused imports
>>>> - remove unused local variables
>>>> - mark methods as deprecated if they override deprecated methods
>>>> - avoid auto-boxing
>>>>
>>>> All unit tess still pass
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestBasicDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestDriverManagerConnectionFactory.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestManual.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TestPStmtPooling.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/TesterCallableStatement.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/cpdsadapter/TestDriverAdapterCPDS.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/PooledConnectionProxy.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestCPDSConnectionFactory.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestInstanceKeyDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestAll.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ jocl/TestJOCLContentHandler.java
>>>>
>>>> Revision: 830110
>>>> Author: markt
>>>> Date: 10:55:10, mardi 27 octobre 2009
>>>> Message:
>>>> Remove unused import
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/KeyedCPDSConnectionFactory.java
>>>>
>>>> Revision: 829661
>>>> Author: markt
>>>> Date: 22:41:41, dimanche 25 octobre 2009
>>>> Message:
>>>> Add recent fixes.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>>
>>>> Revision: 829659
>>>> Author: markt
>>>> Date: 22:37:10, dimanche 25 octobre 2009
>>>> Message:
>>>> Fix DBCP-203. Provide an option to specify the class loader to be  used to load the JDBC driver for a BasicDataSource.
>>>> Based on a patch suggested by Mark Grand.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/BasicDataSource.java
>>>>
>>>> Revision: 829653
>>>> Author: markt
>>>> Date: 22:16:18, dimanche 25 octobre 2009
>>>> Message:
>>>> Extend fix for DBCP-8 to PerUserPoolDataSource
>>>> The fix is a little ugly to maintain binary compatibility in PoolKey  - I really wanted to add password as a separate field
>>>> Unit tests all pass with fix applied
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PerUserPoolDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/datasources/PoolKey.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/datasources/TestPerUserPoolDataSource.java
>>>>
>>>> Revision: 829642
>>>> Author: psteitz
>>>> Date: 21:36:14, dimanche 25 octobre 2009
>>>> Message:
>>>> Improved thread-safety.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/src/test/org/apache/commons/ dbcp/managed/TestBasicManagedDataSource.java
>>>>
>>>> Revision: 829623
>>>> Author: psteitz
>>>> Date: 19:19:37, dimanche 25 octobre 2009
>>>> Message:
>>>> Made XADataSource configurable in BasicManagedDataSource.
>>>> JIRA: DBCP-289
>>>> Reported and patched by Marc Kannegießer.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>>> Modified : /commons/proper/dbcp/trunk/xdocs/changes.xml
>>>>
>>>> Revision: 829618
>>>> Author: psteitz
>>>> Date: 17:57:18, dimanche 25 octobre 2009
>>>> Message:
>>>> Removed deprecated exception class prior to first release of  BasicManagedDataSourc.
>>>> ----
>>>> Modified : /commons/proper/dbcp/trunk/src/java/org/apache/commons/ dbcp/managed/BasicManagedDataSource.java
>>>>
>>>>
>>>> Thanks and sorry for the long post
>>>>
>>>> Jacques
>>>
>>
>>
>
>