completed the test/code separation

[Ganath Rathnayake]

Hi all,
I have completed the test/code separation for all the modules in application
and commited to the git-hub [1].
I like to know the improvements it need to be done.
--
thanks
Ganath

[1]. https://github.com/ganathr/ofbiz

[Erwan de FERRIERES]

Le 07/06/2011 21:52, Ganath Rathnayaka a écrit :
> Hi all,
> I have completed the test/code separation for all the modules in application
> and commited to the git-hub [1].
> I like to know the improvements it need to be done.
Hi Ganath,

I just updated my local copy of your repo, and tried to compile your
work. This isn't working.

You should update the wiki page, explaining what you've done yet.

What we should have is the same functionnalities as before your changes,
so when at the OFBiz's root, i'm running just ant, this is what I get :


BUILD FAILED
/home/erwan/workspace/ofbizGanath/ofbiz/build.xml:206: The following
error occurred while executing this line:
/home/erwan/workspace/ofbizGanath/ofbiz/applications/build.xml:66: The
following error occurred while executing this line:
/home/erwan/workspace/ofbizGanath/ofbiz/macros.xml:32: The following
error occurred while executing this line:
/home/erwan/workspace/ofbizGanath/ofbiz/common.xml:91: srcdir
"/home/erwan/workspace/ofbizGanath/ofbiz/applications/marketing/src"
does not exist!



--
Erwan de FERRIERES
www.nereide.biz

[Ganath Rathnayake]

Sorry about that Erwan,
I added the src folder into git and commited and please let me know if you
have any other issues.
I will update the wiki today afternoon.

Ganath.

[Erwan de FERRIERES]

Le 08/06/2011 03:54, Ganath Rathnayaka a écrit :
> Sorry about that Erwan,
> I added the src folder into git and commited and please let me know if you
> have any other issues.
> I will update the wiki today afternoon.
>
> Ganath.
>
Hi Ganath,

Did you try to compile your modified OFBiz ?
Basic targets like build, run-install and run-tests should be working
before you say the task is completed...

That's a good thing to commit your code, nobody is using it yet, so
there is no problem if it isn't compiling yet. But please test it before
saying it's completed...


Cheers,

--
Erwan de FERRIERES
www.nereide.biz

[Ganath Rathnayake]

Hi Erwan,
I did ran the ant run-install before I commit. What my fault was that it
didn't include the marketing/src folder in to the git. So it showed me no
error. Currently I am running the tests and hoping to keep you update with
the results of it.

thanks
Ganath

[Erwan de FERRIERES]

Le 08/06/2011 13:04, Ganath Rathnayaka a écrit :
> Hi Erwan,
> I did ran the ant run-install before I commit. What my fault was that it
> didn't include the marketing/src folder in to the git. So it showed me no
> error. Currently I am running the tests and hoping to keep you update with
> the results of it.
>
Nice then !

So please also run them from the root folder, it will then work on all
the components.

And update on the wiki page what you're working on, this will help you
and others if they need informations on the code migration.

Cheers,

> thanks
> Ganath
>


--
Erwan de FERRIERES
www.nereide.biz