configproductdetail.ftl useless block

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

configproductdetail.ftl useless block

Jacques Le Roux
Administrator
In both configproductdetail.ftl files, we have this whole useless block

if (data._ERROR_MESSAGE_LIST_ != undefined) {
   //console.log(data._ERROR_MESSAGE_LIST_);
   //alert(data._ERROR_MESSAGE_LIST_);
}else if (data._ERROR_MESSAGE_ != undefined) {
   //console.log(data._ERROR_MESSAGE_);
   //alert(data._ERROR_MESSAGE_);
}else {
  //console.log(data.totalPrice);
  //console.log(data.configId);

Is there a reason to keep it?

Jacques
Reply | Threaded
Open this post in threaded view
|

Re: configproductdetail.ftl useless block

Bilgin Ibryam-2
If I remember correct, it was used for debugging purpose and it is
safe to delete/cleanup.

The more interesting questions is do we have a generic way in place to
extract/display error/warning messages generated by ajax requests?

Bilgin

On Wed, Oct 12, 2011 at 10:15 AM, Jacques Le Roux
<[hidden email]> wrote:

> In both configproductdetail.ftl files, we have this whole useless block
>
> if (data._ERROR_MESSAGE_LIST_ != undefined) {
>  //console.log(data._ERROR_MESSAGE_LIST_);
>  //alert(data._ERROR_MESSAGE_LIST_);
> }else if (data._ERROR_MESSAGE_ != undefined) {
>  //console.log(data._ERROR_MESSAGE_);
>  //alert(data._ERROR_MESSAGE_);
> }else {
>  //console.log(data.totalPrice);
>  //console.log(data.configId);
>
> Is there a reason to keep it?
>
> Jacques
>
Reply | Threaded
Open this post in threaded view
|

Re: configproductdetail.ftl useless block

Jacques Le Roux
Administrator
The answer is less interesting: I think we don't...so far. Do you have an idea?

Jacques

From: "Bilgin Ibryam" <[hidden email]>

> If I remember correct, it was used for debugging purpose and it is
> safe to delete/cleanup.
>
> The more interesting questions is do we have a generic way in place to
> extract/display error/warning messages generated by ajax requests?
>
> Bilgin
>
> On Wed, Oct 12, 2011 at 10:15 AM, Jacques Le Roux
> <[hidden email]> wrote:
>> In both configproductdetail.ftl files, we have this whole useless block
>>
>> if (data._ERROR_MESSAGE_LIST_ != undefined) {
>> //console.log(data._ERROR_MESSAGE_LIST_);
>> //alert(data._ERROR_MESSAGE_LIST_);
>> }else if (data._ERROR_MESSAGE_ != undefined) {
>> //console.log(data._ERROR_MESSAGE_);
>> //alert(data._ERROR_MESSAGE_);
>> }else {
>> //console.log(data.totalPrice);
>> //console.log(data.configId);
>>
>> Is there a reason to keep it?
>>
>> Jacques
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: configproductdetail.ftl useless block

Bilgin Ibryam-2
On Fri, Oct 21, 2011 at 6:10 PM, Jacques Le Roux
<[hidden email]> wrote:
> The answer is less interesting: I think we don't...so far. Do you have an
> idea?
>

I can see that there are code snippet doing it, but they are copied
and pasted in various places already. For example selectall.js, lines
350 to 370

It would be better to have only one js function, that checks the ajax
responses for error messages and displays in the framework.

my 2 cents

Bilgin


> Jacques
>
> From: "Bilgin Ibryam" <[hidden email]>
>>
>> If I remember correct, it was used for debugging purpose and it is
>> safe to delete/cleanup.
>>
>> The more interesting questions is do we have a generic way in place to
>> extract/display error/warning messages generated by ajax requests?
>>
>> Bilgin
>>
>> On Wed, Oct 12, 2011 at 10:15 AM, Jacques Le Roux
>> <[hidden email]> wrote:
>>>
>>> In both configproductdetail.ftl files, we have this whole useless block
>>>
>>> if (data._ERROR_MESSAGE_LIST_ != undefined) {
>>> //console.log(data._ERROR_MESSAGE_LIST_);
>>> //alert(data._ERROR_MESSAGE_LIST_);
>>> }else if (data._ERROR_MESSAGE_ != undefined) {
>>> //console.log(data._ERROR_MESSAGE_);
>>> //alert(data._ERROR_MESSAGE_);
>>> }else {
>>> //console.log(data.totalPrice);
>>> //console.log(data.configId);
>>>
>>> Is there a reason to keep it?
>>>
>>> Jacques
>>>
>>
>