fieldErrors macro

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

fieldErrors macro

Abdullah Shaikh-3
For displaying the error messages right besides the input fields, I am using
"fieldErrors" macro, which I copied from ecommerce's newcustomer.ftl. I have
seen that the macro is being used in 2 ftl files newcustmer.ftl &
quickAnonCustSettings.ftl, in which the macro is copy/pasted.

Can we move the macro "fieldErrors" & "fieldErrorsMulti" in some common ftl
file so that when required we can import the common ftl file and use the
macro instead of doing copy/paste.

In my component I have created a common ftl file, but it will be better if
we can have this in ofbiz itself. what say ?
Reply | Threaded
Open this post in threaded view
|

Re: fieldErrors macro

Jacques Le Roux-2-2
Are you aware of the messages.ftl files ?

Jacques

From: "Abdullah Shaikh" <[hidden email]>

> For displaying the error messages right besides the input fields, I am using
> "fieldErrors" macro, which I copied from ecommerce's newcustomer.ftl. I have
> seen that the macro is being used in 2 ftl files newcustmer.ftl &
> quickAnonCustSettings.ftl, in which the macro is copy/pasted.
>
> Can we move the macro "fieldErrors" & "fieldErrorsMulti" in some common ftl
> file so that when required we can import the common ftl file and use the
> macro instead of doing copy/paste.
>
> In my component I have created a common ftl file, but it will be better if
> we can have this in ofbiz itself. what say ?
>
Reply | Threaded
Open this post in threaded view
|

Re: fieldErrors macro

Abdullah Shaikh-3
Yes I am aware of messages.ftl file, but what I meant was, if the user want
to display the error message just beside (or somewhere around) the input
field, and not as a whole in a single div.

On Sat, Aug 29, 2009 at 11:26 PM, Jacques Le Roux
<[hidden email]>wrote:

> Are you aware of the messages.ftl files ?
>
> Jacques
>
> From: "Abdullah Shaikh" <[hidden email]>
>
>  For displaying the error messages right besides the input fields, I am
>> using
>> "fieldErrors" macro, which I copied from ecommerce's newcustomer.ftl. I
>> have
>> seen that the macro is being used in 2 ftl files newcustmer.ftl &
>> quickAnonCustSettings.ftl, in which the macro is copy/pasted.
>>
>> Can we move the macro "fieldErrors" & "fieldErrorsMulti" in some common
>> ftl
>> file so that when required we can import the common ftl file and use the
>> macro instead of doing copy/paste.
>>
>> In my component I have created a common ftl file, but it will be better if
>> we can have this in ofbiz itself. what say ?
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: fieldErrors macro

Jacques Le Roux-2-2
I see, I missed the "right" in "right besides", still need some improvment in English (though I'd have suggested "right besides each
input field" ;o)
More seriously, I also suggest a Jira and a patch, look for contributors best practices in Wiki if you don't them already.
I'd also suggest commonMacros.ftl

Thanks

Jacques

From: "Abdullah Shaikh" <[hidden email]>

> Yes I am aware of messages.ftl file, but what I meant was, if the user want
> to display the error message just beside (or somewhere around) the input
> field, and not as a whole in a single div.
>
> On Sat, Aug 29, 2009 at 11:26 PM, Jacques Le Roux
> <[hidden email]>wrote:
>
>> Are you aware of the messages.ftl files ?
>>
>> Jacques
>>
>> From: "Abdullah Shaikh" <[hidden email]>
>>
>>  For displaying the error messages right besides the input fields, I am
>>> using
>>> "fieldErrors" macro, which I copied from ecommerce's newcustomer.ftl. I
>>> have
>>> seen that the macro is being used in 2 ftl files newcustmer.ftl &
>>> quickAnonCustSettings.ftl, in which the macro is copy/pasted.
>>>
>>> Can we move the macro "fieldErrors" & "fieldErrorsMulti" in some common
>>> ftl
>>> file so that when required we can import the common ftl file and use the
>>> macro instead of doing copy/paste.
>>>
>>> In my component I have created a common ftl file, but it will be better if
>>> we can have this in ofbiz itself. what say ?
>>>
>>>
>

Reply | Threaded
Open this post in threaded view
|

Re: fieldErrors macro

Abdullah Shaikh
Hi Jacques,

Created Jira issue & patch, https://issues.apache.org/jira/browse/OFBIZ-2890

Thanks,
Abdullah

On Mon, Aug 31, 2009 at 1:47 PM, Jacques Le Roux <[hidden email]>wrote:

> I see, I missed the "right" in "right besides", still need some improvment
> in English (though I'd have suggested "right besides each input field" ;o)
> More seriously, I also suggest a Jira and a patch, look for contributors
> best practices in Wiki if you don't them already.
> I'd also suggest commonMacros.ftl
>
> Thanks
>
>
> Jacques
>
> From: "Abdullah Shaikh" <[hidden email]>
>
>> Yes I am aware of messages.ftl file, but what I meant was, if the user
>> want
>> to display the error message just beside (or somewhere around) the input
>> field, and not as a whole in a single div.
>>
>> On Sat, Aug 29, 2009 at 11:26 PM, Jacques Le Roux
>> <[hidden email]>wrote:
>>
>>  Are you aware of the messages.ftl files ?
>>>
>>> Jacques
>>>
>>> From: "Abdullah Shaikh" <[hidden email]>
>>>
>>>  For displaying the error messages right besides the input fields, I am
>>>
>>>> using
>>>> "fieldErrors" macro, which I copied from ecommerce's newcustomer.ftl. I
>>>> have
>>>> seen that the macro is being used in 2 ftl files newcustmer.ftl &
>>>> quickAnonCustSettings.ftl, in which the macro is copy/pasted.
>>>>
>>>> Can we move the macro "fieldErrors" & "fieldErrorsMulti" in some common
>>>> ftl
>>>> file so that when required we can import the common ftl file and use the
>>>> macro instead of doing copy/paste.
>>>>
>>>> In my component I have created a common ftl file, but it will be better
>>>> if
>>>> we can have this in ofbiz itself. what say ?
>>>>
>>>>
>>>>
>>
>