framework/sql to Attic

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

framework/sql to Attic

Jacopo Cappellato-4
Hi all,

I would like to move to Attic (i.e. remove from the trunk) the
framework/sql component and the entity classes dependent on it (i.e. the
java package org.ofbiz.entity.sql): if memory serves, no client code (from
applications and specialpurpose) ever used this API and I have never heard
about questions about this in the dev or user lists, nor Jira tickets
created for bugs or enhancements in this area; these are all indications
that this code may be a dead experiment; the last significant commit is in
2010 and seems to indicate an incomplete feature: "FEATURE: Start of union
support; parsing isn't tested yet.".
I doubt that removing it will have any impact.

Any objections?

Best regards,

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: framework/sql to Attic

Adrian Crum-3
FYI: That component was an attempt to create a specialized SQL parser
for the OFBiz entity engine. The idea was to use a standardized SQL
string that the parser would convert to entity conditions and Delegator
calls. So, you could use the same SQL string on any database.

You are correct - the component was never finished, and I agree that it
should be moved to the attic.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 12/9/2014 3:30 PM, Jacopo Cappellato wrote:

> Hi all,
>
> I would like to move to Attic (i.e. remove from the trunk) the
> framework/sql component and the entity classes dependent on it (i.e. the
> java package org.ofbiz.entity.sql): if memory serves, no client code (from
> applications and specialpurpose) ever used this API and I have never heard
> about questions about this in the dev or user lists, nor Jira tickets
> created for bugs or enhancements in this area; these are all indications
> that this code may be a dead experiment; the last significant commit is in
> 2010 and seems to indicate an incomplete feature: "FEATURE: Start of union
> support; parsing isn't tested yet.".
> I doubt that removing it will have any impact.
>
> Any objections?
>
> Best regards,
>
> Jacopo
>
Reply | Threaded
Open this post in threaded view
|

Re: framework/sql to Attic

Jacopo Cappellato-4
On Dec 9, 2014, at 5:06 PM, Adrian Crum <[hidden email]> wrote:

> FYI: That component was an attempt to create a specialized SQL parser for the OFBiz entity engine. The idea was to use a standardized SQL string that the parser would convert to entity conditions and Delegator calls. So, you could use the same SQL string on any database.

Yes, I remember the idea and the commits; I was planning to add a short summary of the feature in the Attic page, and your paragraph above is a perfect one!

>
> You are correct - the component was never finished, and I agree that it should be moved to the attic.

Thanks for the feedback Adrian

Jacopo

>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 12/9/2014 3:30 PM, Jacopo Cappellato wrote:
>> Hi all,
>>
>> I would like to move to Attic (i.e. remove from the trunk) the
>> framework/sql component and the entity classes dependent on it (i.e. the
>> java package org.ofbiz.entity.sql): if memory serves, no client code (from
>> applications and specialpurpose) ever used this API and I have never heard
>> about questions about this in the dev or user lists, nor Jira tickets
>> created for bugs or enhancements in this area; these are all indications
>> that this code may be a dead experiment; the last significant commit is in
>> 2010 and seems to indicate an incomplete feature: "FEATURE: Start of union
>> support; parsing isn't tested yet.".
>> I doubt that removing it will have any impact.
>>
>> Any objections?
>>
>> Best regards,
>>
>> Jacopo
>>

Reply | Threaded
Open this post in threaded view
|

Re: framework/sql to Attic

Jacopo Cappellato-4
This is done:

https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic

Jacopo

On Dec 10, 2014, at 10:20 AM, Jacopo Cappellato <[hidden email]> wrote:

> On Dec 9, 2014, at 5:06 PM, Adrian Crum <[hidden email]> wrote:
>
>> FYI: That component was an attempt to create a specialized SQL parser for the OFBiz entity engine. The idea was to use a standardized SQL string that the parser would convert to entity conditions and Delegator calls. So, you could use the same SQL string on any database.
>
> Yes, I remember the idea and the commits; I was planning to add a short summary of the feature in the Attic page, and your paragraph above is a perfect one!
>
>>
>> You are correct - the component was never finished, and I agree that it should be moved to the attic.
>
> Thanks for the feedback Adrian
>
> Jacopo
>
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 12/9/2014 3:30 PM, Jacopo Cappellato wrote:
>>> Hi all,
>>>
>>> I would like to move to Attic (i.e. remove from the trunk) the
>>> framework/sql component and the entity classes dependent on it (i.e. the
>>> java package org.ofbiz.entity.sql): if memory serves, no client code (from
>>> applications and specialpurpose) ever used this API and I have never heard
>>> about questions about this in the dev or user lists, nor Jira tickets
>>> created for bugs or enhancements in this area; these are all indications
>>> that this code may be a dead experiment; the last significant commit is in
>>> 2010 and seems to indicate an incomplete feature: "FEATURE: Start of union
>>> support; parsing isn't tested yet.".
>>> I doubt that removing it will have any impact.
>>>
>>> Any objections?
>>>
>>> Best regards,
>>>
>>> Jacopo
>>>
>