including code from another apache lic program

[BJ Freeman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jgeocode is on source forge.
it is part of the addressing.
has some very powerful regex libraries for address normalization.
However that code uses tiger data.
I have modified it to use ofbiz geo, and the new address format.
the question, can I just include the code as I have modified it, or do I
have to make a jar out of it first, just include the jar.
seems I could just include the source that I have modified.
currently it is in
org.ofbiz.party.postal

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJucJXrP3NbaWWqE4RAuIjAKC+PYhOCjlRxKacZYrKarD/ckFfAACgg9rQ
KwdPeqAjkBahsWkuW15aSGQ=
=MOcX
-----END PGP SIGNATURE-----

[Jacques Le Roux]

From: "BJ Freeman" <[hidden email]>

> Jgeocode is on source forge.
> it is part of the addressing.
> has some very powerful regex libraries for address normalization.
> However that code uses tiger data.
> I have modified it to use ofbiz geo, and the new address format.
> the question, can I just include the code as I have modified it, or do I
> have to make a jar out of it first, just include the jar.
> seems I could just include the source that I have modified.
> currently it is in
> org.ofbiz.party.postal

I suppose you speak about Jgeocoder (not Jgeocode but JgeocodeR)

I did not find any clear licence on sourceforge (googled for "site:jgeocoder.sourceforge.net licence")
They created a wiki on codehaus but even there you may use ASL2 non compatible licences
http://docs.codehaus.org/display/HAUS/Business+Friendly+Licence

I suggest to ask Jgeocoder team to clarify this aspect

Thanks

Jacques

[BJ Freeman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

thanks
the POM.XML in the svn shows
<licenses>
  <license>
  <name>Apache License 2.0</name>
  <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
  </license>
  </licenses>


Jacques Le Roux sent the following on 3/17/2009 2:08 AM:

> From: "BJ Freeman" <[hidden email]>
>> Jgeocode is on source forge.
>> it is part of the addressing.
>> has some very powerful regex libraries for address normalization.
>> However that code uses tiger data.
>> I have modified it to use ofbiz geo, and the new address format.
>> the question, can I just include the code as I have modified it, or do I
>> have to make a jar out of it first, just include the jar.
>> seems I could just include the source that I have modified.
>> currently it is in
>> org.ofbiz.party.postal
>
> I suppose you speak about Jgeocoder (not Jgeocode but JgeocodeR)
>
> I did not find any clear licence on sourceforge (googled for
> "site:jgeocoder.sourceforge.net licence")
> They created a wiki on codehaus but even there you may use ASL2 non
> compatible licences
> http://docs.codehaus.org/display/HAUS/Business+Friendly+Licence
>
> I suggest to ask Jgeocoder team to clarify this aspect
>
> Thanks
>
> Jacques
>
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJv3MfrP3NbaWWqE4RAkvkAJ47BLKwDxY3ziPFMH7uEjOW3O19NQCfaoWA
v8uPfJtB9qIG/rD5DdBTdD8=
=aPMF
-----END PGP SIGNATURE-----

[Jacques Le Roux]

Then no problems, you can do anything you want with this code, including include it in OFBiz...

Jacques

From: "BJ Freeman" <[hidden email]>

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> thanks
> the POM.XML in the svn shows
> <licenses>
>  <license>
>  <name>Apache License 2.0</name>
>  <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
>  </license>
>  </licenses>
>
>
> Jacques Le Roux sent the following on 3/17/2009 2:08 AM:
>> From: "BJ Freeman" <[hidden email]>
>>> Jgeocode is on source forge.
>>> it is part of the addressing.
>>> has some very powerful regex libraries for address normalization.
>>> However that code uses tiger data.
>>> I have modified it to use ofbiz geo, and the new address format.
>>> the question, can I just include the code as I have modified it, or do I
>>> have to make a jar out of it first, just include the jar.
>>> seems I could just include the source that I have modified.
>>> currently it is in
>>> org.ofbiz.party.postal
>>
>> I suppose you speak about Jgeocoder (not Jgeocode but JgeocodeR)
>>
>> I did not find any clear licence on sourceforge (googled for
>> "site:jgeocoder.sourceforge.net licence")
>> They created a wiki on codehaus but even there you may use ASL2 non
>> compatible licences
>> http://docs.codehaus.org/display/HAUS/Business+Friendly+Licence
>>
>> I suggest to ask Jgeocoder team to clarify this aspect
>>
>> Thanks
>>
>> Jacques
>>
>>
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFJv3MfrP3NbaWWqE4RAkvkAJ47BLKwDxY3ziPFMH7uEjOW3O19NQCfaoWA
> v8uPfJtB9qIG/rD5DdBTdD8=
> =aPMF
> -----END PGP SIGNATURE-----
>

[Jacques Le Roux]

More to the point, answering your question "should I provide a modified jar or code". I think it's would be better if we could rely
on their code with just some modifications on our side. The idea is to prevent the same scenario than Minerva where the core team
had to maintain its own code. Not sure how to deal with that in this case. Why not opening a Jira issue and begin to show more
things ?

Jacques

From: "Jacques Le Roux" <[hidden email]>

> Then no problems, you can do anything you want with this code, including include it in OFBiz...
>
> Jacques
>
> From: "BJ Freeman" <[hidden email]>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> thanks
>> the POM.XML in the svn shows
>> <licenses>
>>  <license>
>>  <name>Apache License 2.0</name>
>>  <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
>>  </license>
>>  </licenses>
>>
>>
>> Jacques Le Roux sent the following on 3/17/2009 2:08 AM:
>>> From: "BJ Freeman" <[hidden email]>
>>>> Jgeocode is on source forge.
>>>> it is part of the addressing.
>>>> has some very powerful regex libraries for address normalization.
>>>> However that code uses tiger data.
>>>> I have modified it to use ofbiz geo, and the new address format.
>>>> the question, can I just include the code as I have modified it, or do I
>>>> have to make a jar out of it first, just include the jar.
>>>> seems I could just include the source that I have modified.
>>>> currently it is in
>>>> org.ofbiz.party.postal
>>>
>>> I suppose you speak about Jgeocoder (not Jgeocode but JgeocodeR)
>>>
>>> I did not find any clear licence on sourceforge (googled for
>>> "site:jgeocoder.sourceforge.net licence")
>>> They created a wiki on codehaus but even there you may use ASL2 non
>>> compatible licences
>>> http://docs.codehaus.org/display/HAUS/Business+Friendly+Licence
>>>
>>> I suggest to ask Jgeocoder team to clarify this aspect
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.6 (MingW32)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iD8DBQFJv3MfrP3NbaWWqE4RAkvkAJ47BLKwDxY3ziPFMH7uEjOW3O19NQCfaoWA
>> v8uPfJtB9qIG/rD5DdBTdD8=
>> =aPMF
>> -----END PGP SIGNATURE-----
>>
>

[BJ Freeman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I am documenting it first on the wiki.
as I said in another email it will take me about a month
and in the past I have been informed not to open a jira till I have a patch.
so I will once all the code is tested against the current, at that time,
svn.
Hope this meets with everyones approval.

Jacques Le Roux sent the following on 3/17/2009 5:35 AM:

> More to the point, answering your question "should I provide a modified
> jar or code". I think it's would be better if we could rely on their
> code with just some modifications on our side. The idea is to prevent
> the same scenario than Minerva where the core team had to maintain its
> own code. Not sure how to deal with that in this case. Why not opening a
> Jira issue and begin to show more things ?
>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> Then no problems, you can do anything you want with this code,
>> including include it in OFBiz...
>>
>> Jacques
>>
>> From: "BJ Freeman" <[hidden email]>
> thanks
> the POM.XML in the svn shows
> <licenses>
>  <license>
>  <name>Apache License 2.0</name>
>  <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
>  </license>
>  </licenses>
>
>
> Jacques Le Roux sent the following on 3/17/2009 2:08 AM:
>>>>> From: "BJ Freeman" <[hidden email]>
>>>>>> Jgeocode is on source forge.
>>>>>> it is part of the addressing.
>>>>>> has some very powerful regex libraries for address normalization.
>>>>>> However that code uses tiger data.
>>>>>> I have modified it to use ofbiz geo, and the new address format.
>>>>>> the question, can I just include the code as I have modified it, or
>>>>>> do I
>>>>>> have to make a jar out of it first, just include the jar.
>>>>>> seems I could just include the source that I have modified.
>>>>>> currently it is in
>>>>>> org.ofbiz.party.postal
>>>>>
>>>>> I suppose you speak about Jgeocoder (not Jgeocode but JgeocodeR)
>>>>>
>>>>> I did not find any clear licence on sourceforge (googled for
>>>>> "site:jgeocoder.sourceforge.net licence")
>>>>> They created a wiki on codehaus but even there you may use ASL2 non
>>>>> compatible licences
>>>>> http://docs.codehaus.org/display/HAUS/Business+Friendly+Licence
>>>>>
>>>>> I suggest to ask Jgeocoder team to clarify this aspect
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>>
>>>>>
>>>
>>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJv79QrP3NbaWWqE4RAtHRAKCmPKkDeGEj+OQRKGzov2hznfoUhQCfXCIE
BQ0lF/vRSbEneQa25xKeEmw=
=zvFw
-----END PGP SIGNATURE-----