[jira] [Assigned] (OFBIZ-9578) Collection added to itself

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-9578:
--------------------------------------

    Assignee: Jacques Le Roux

> Collection added to itself
> --------------------------
>
>                 Key: OFBIZ-9578
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9578
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: JC
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
> {code:java}
> ...
> 1588         protected final List<String> messages = new LinkedList<String>();
> ...
> 1596         protected int updateData(Collection<String> messages) {
> 1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
> 1598                 messages.addAll(messages);
> 1599             }
> 1600             return count;
> 1601         }
> 1602     }
> {code}
> In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue but I wanted to report this just in case.
> Thanks!

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)