[jira] [Closed] (OFBIZ-10649) Simplification of the service callback handling

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-10649.
-----------------------------------
    Resolution: Implemented

Thanks Mathieu,

Your patch is in trunk at revision: 1846783  

I must say I had to come back to http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/AbstractEngine.java?r1=586468&r2=586467&pathrev=586468
to understand from what {{allowCallbacks}} was derived.

> Simplification of the service callback handling
> -----------------------------------------------
>
>                 Key: OFBIZ-10649
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10649
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10649_Refactor-the-service-callback-handling.patch
>
>
> The service callback handling done in {{org.apache.ofbiz.service.engine.AbstractEngine}} can be rewritten more nicely without explicit iterators. Additionally it is not nice that the engine is responsible for removing disabled callbacks. The {{ServiceDispatcher}} should be responsible for removing them.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)