[jira] [Closed] (OFBIZ-10929) Duplicate a ShoppingCartItem didn't propage OrderItemAttributes

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin closed OFBIZ-10929.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 18.12.01
                   Upcoming Branch
                   16.11.06
                   17.12.01

> Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10929
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10929
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>             Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
>
> When you clone a ShoppingCartItem by constructor
> {code:java}
> new ShoppingCartItem(ShoppingCartItem item){code}
> Values contains on list OrderItemAttributes aren't propage to the new shoppingCartItem due to (ShoppingCartItem.java:682)
> {code:java}
> if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
>  this.orderItemAttributes = new HashMap<>();
>  this.orderItemAttributes.putAll(item.getOrderItemAttributes());
> }
> {code}
> isEmpty instead of isNotEmpty

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)