[jira] [Closed] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suraj Khurana closed OFBIZ-11804.
---------------------------------
    Fix Version/s: Upcoming Branch
       Resolution: Implemented

All 6 PR's for separate components have been pushed into latest trunk repo.

 

> Change decimals, rounding, zero static variables names as per best practices
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-11804
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11804
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>
> As we have done it for modules, resources, it is better to get this done for all similar variables as well.
> decimals -> DECIMALS
> rounding -> ROUNDING
> zero -> ZERO
> Also, we should make these variables as private instead of public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)