[jira] [Closed] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suraj Khurana closed OFBIZ-11941.
---------------------------------
    Fix Version/s: Upcoming Branch
       Resolution: Implemented

This fixed around *1925* checkstyle issues.

> Checkstyle: Add override property in DesignForExtension module
> --------------------------------------------------------------
>
>                 Key: OFBIZ-11941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11941
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11941.patch
>
>
> While performing checks for class design it is mandatory to provide javadoc, we can skip override methods from this checkstyle check.
> Sample error:
> Class 'ABC' looks like designed for extension (can be subclassed), but the method 'xyz' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ABC' final or making the method 'xyz' static/final/abstract/empty, or adding allowed annotation for the method.
> <module name="DesignForExtension">
>  <property name="ignoredAnnotations"
>  value="After, AfterClass, Before, BeforeClass, Test, Property, *Override*"/>
> </module>

--
This message was sent by Atlassian Jira
(v8.3.4#803005)