OFBiz › OFBiz - Dev

[jira] Closed: (OFBIZ-270) USPS Rate Estimation

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-270) USPS Rate Estimation

[ https://issues.apache.org/jira/browse/OFBIZ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-270.
---------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

It's now

public static String urlEncodeArgs(Map args, boolean useExpandedEntites) {
...
if (valueStr != null && valueStr.length() > 0) {
if (buf.length() > 0) {
if (useExpandedEntites) {
buf.append("&");
} else {
buf.append("&");
}
}
...

and I guess it subsumes your change so I let it like that and applied the rest of the patch with some few minor refactoring (few ending lines tabs and debug unneeded) in OFBiz rev. 495725

> USPS Rate Estimation
> --------------------
>
> Key: OFBIZ-270
> URL: https://issues.apache.org/jira/browse/OFBIZ-270
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: Any
> Reporter: Marco Risaliti
> Assigned To: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: shipping.patch
>
>
> This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel
> ===========================================================
> The USPS automatic Rate Inquiry module has numerous flaws.
> I was able to find and fix them, albeit, with potentially unacceptable techniques.
> Specifically:
> 1.) USPS now uses Get and does not Post any longer.
> 2.) Pounds must be a integer number.
> 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too)
> 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of &
> !!!! My fix for this issue may not be appropriate!
> 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound.
> Remaining Issues...
> Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage.
> Need to add International Shipping Support.
> Finally... This is my first patch contribution... It will need extra time and attention to verify!
> Thanks
> Daniel
>
>
> All Comments Work Log Change History Sort Order:
> Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ]
> My fixes which SEEM to work. Your milage may vary.
> Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ]
> Can be closed ?
> Thanks
> Marco
> Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ]
> I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed.
> PS. I do have an iCLA signed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Adrian Crum

Re: [jira] Closed: (OFBIZ-270) USPS Rate Estimation

Let's hope the line

if (useExpandedEntites)

was corrected before committing it.

Jacques Le Roux (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacques Le Roux closed OFBIZ-270.
> ---------------------------------
>
> Resolution: Fixed
> Fix Version/s: SVN trunk
>
> It's now
>
> public static String urlEncodeArgs(Map args, boolean useExpandedEntites) {
> ...
> if (valueStr != null && valueStr.length() > 0) {
> if (buf.length() > 0) {
> if (useExpandedEntites) {
> buf.append("&");
> } else {
> buf.append("&");
> }
> }
> ...
>
> and I guess it subsumes your change so I let it like that and applied the rest of the patch with some few minor refactoring (few ending lines tabs and debug unneeded) in OFBiz rev. 495725
>
>
>
>
>>USPS Rate Estimation
>>--------------------
>>
>> Key: OFBIZ-270
>> URL: https://issues.apache.org/jira/browse/OFBIZ-270
>> Project: Apache OFBiz (The Open for Business Project)
>> Issue Type: Bug
>> Components: product
>> Affects Versions: SVN trunk
>> Environment: Any
>> Reporter: Marco Risaliti
>> Assigned To: Jacques Le Roux
>> Priority: Minor
>> Fix For: SVN trunk
>>
>> Attachments: shipping.patch
>>
>>
>>This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel
>>===========================================================
>>The USPS automatic Rate Inquiry module has numerous flaws.
>>I was able to find and fix them, albeit, with potentially unacceptable techniques.
>>Specifically:
>>1.) USPS now uses Get and does not Post any longer.
>>2.) Pounds must be a integer number.
>>3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too)
>>4.) The HttpClient HTTP GET was inserting & between the value pairs instead of &
>>!!!! My fix for this issue may not be appropriate!
>>5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound.
>>Remaining Issues...
>>Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage.
>>Need to add International Shipping Support.
>>Finally... This is my first patch contribution... It will need extra time and attention to verify!
>>Thanks
>>Daniel
>>
>>
>> All Comments Work Log Change History Sort Order:
>>Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ]
>>My fixes which SEEM to work. Your milage may vary.
>>Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ]
>>Can be closed ?
>>Thanks
>>Marco
>>Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ]
>>I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed.
>>PS. I do have an iCLA signed.
>
>

Jacques Le Roux

Re: [jira] Closed: (OFBIZ-270) USPS Rate Estimation

Administrator

Adrian,

I'm not sure to understand you because I did *not* commit this part of the patch. I thought I was clear though, do you think I may
have missed something ?

Jacques

----- Original Message -----
From: "Adrian Crum" <[hidden email]>
To: <[hidden email]>
Sent: Friday, January 12, 2007 9:37 PM
Subject: Re: [jira] Closed: (OFBIZ-270) USPS Rate Estimation

> Let's hope the line
>
> if (useExpandedEntites)
>
> was corrected before committing it.
>
>
> Jacques Le Roux (JIRA) wrote:
>
> > [ https://issues.apache.org/jira/browse/OFBIZ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Jacques Le Roux closed OFBIZ-270.
> > ---------------------------------
> >
> > Resolution: Fixed
> > Fix Version/s: SVN trunk
> >
> > It's now
> >
> > public static String urlEncodeArgs(Map args, boolean useExpandedEntites) {
> > ...
> > if (valueStr != null && valueStr.length() > 0) {
> > if (buf.length() > 0) {
> > if (useExpandedEntites) {
> > buf.append("&");
> > } else {
> > buf.append("&");
> > }
> > }
> > ...
> >
> > and I guess it subsumes your change so I let it like that and applied the rest of the patch with some few minor refactoring (few

ending lines tabs and debug unneeded) in OFBiz rev. 495725

> >
> >
> >
> >
> >>USPS Rate Estimation
> >>--------------------
> >>
> >> Key: OFBIZ-270
> >> URL: https://issues.apache.org/jira/browse/OFBIZ-270
> >> Project: Apache OFBiz (The Open for Business Project)
> >> Issue Type: Bug
> >> Components: product
> >> Affects Versions: SVN trunk
> >> Environment: Any
> >> Reporter: Marco Risaliti
> >> Assigned To: Jacques Le Roux
> >> Priority: Minor
> >> Fix For: SVN trunk
> >>
> >> Attachments: shipping.patch
> >>
> >>
> >>This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel
> >>===========================================================
> >>The USPS automatic Rate Inquiry module has numerous flaws.
> >>I was able to find and fix them, albeit, with potentially unacceptable techniques.
> >>Specifically:
> >>1.) USPS now uses Get and does not Post any longer.
> >>2.) Pounds must be a integer number.
> >>3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too)
> >>4.) The HttpClient HTTP GET was inserting & between the value pairs instead of &
> >>!!!! My fix for this issue may not be appropriate!
> >>5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while

shipping defaulted to the pound.
> >>Remaining Issues...
> >>Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money
loosing postage.

> >>Need to add International Shipping Support.
> >>Finally... This is my first patch contribution... It will need extra time and attention to verify!
> >>Thanks
> >>Daniel
> >>
> >>
> >> All Comments Work Log Change History Sort Order:
> >>Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ]
> >>My fixes which SEEM to work. Your milage may vary.
> >>Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ]
> >>Can be closed ?
> >>Thanks
> >>Marco
> >>Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ]
> >>I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I

don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business.
Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed.
> >>PS. I do have an iCLA signed.
> >
> >