[jira] [Closed] (OFBIZ-2889) action list in form inheritance

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2889.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Nicolas,

Your patch is in trunk at revision: 1293565

The XSDs are up to date on OFBiz site

Well done, it would have been perfect if you had given to me the url/process you used to test LookupContent, I used Facility content ;)
We could also have added an xsd documentation but I think the name explains pretty well.

Also did you test the row-action part? (I did not)

               

> action list in form inheritance
> -------------------------------
>
>                 Key: OFBIZ-2889
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2889
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Harmeet Bedi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 0FBIZ-4718.patch, ModelForm.java.diff, widget-form.xsd.diff
>
>
> Purpose: make inheritance options more flexible and document them better for end user consumption.
> Following XSD attributes
> <xs:attribute name="extends-actions" default="override">
>  <xs:annotation>
>    <xs:documentation>If form derives from parent, form actions may
>      override existing parent form actions, append to parent form actions or ignore
>      parent form actions</xs:documentation>
>  </xs:annotation>
>  <xs:simpleType>
>    <xs:restriction base="xs:token">
>      <xs:enumeration value="append">
>        <xs:annotation>
>          <xs:documentation>append form actions to list of parent form actions</xs:documentation>
>        </xs:annotation>
>      </xs:enumeration>
>      <xs:enumeration value="prepend">
>        <xs:annotation>
>          <xs:documentation>prepend form actions to list of parent form actions</xs:documentation>
>        </xs:annotation>
>      </xs:enumeration>
>      <xs:enumeration value="override">
>        <xs:annotation>
>          <xs:documentation>If action block exists, ignore parent action list.
>                            If action block does not exist use the parent action list
>          </xs:documentation>
>        </xs:annotation>
>      </xs:enumeration>
>      <xs:enumeration value="ignore">
>        <xs:annotation>
>          <xs:documentation>Ignore parent form actions.
>                            Same as override with no actions specified in actions block.
>          </xs:documentation>
>        </xs:annotation>
>      </xs:enumeration>
>    </xs:restriction>
>  </xs:simpleType>
> </xs:attribute>
> same for
> <xs:attribute name="extends-row-actions" default="override">
> ....
> </xs:attribute>
> Attaching patches for xsd and ModelForm

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Malin Nicolas]

Excuse me Jacques for the waste. I made a check directly on content by
EditContent form.
I don't find a example for row-actions without adding a new code, but if
I found it in the future I will submit it ;)
For the xsd documentation, just a miss, I try to correct this.

Thanks Jacques for your review
Nicolas
Le 25/02/2012 11:05, Jacques Le Roux (Closed) (JIRA) a écrit :

>       [ https://issues.apache.org/jira/browse/OFBIZ-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacques Le Roux closed OFBIZ-2889.
> ----------------------------------
>
>      Resolution: Fixed
>        Assignee: Jacques Le Roux
>
> Thanks Nicolas,
>
> Your patch is in trunk at revision: 1293565
>
> The XSDs are up to date on OFBiz site
>
> Well done, it would have been perfect if you had given to me the url/process you used to test LookupContent, I used Facility content ;)
> We could also have added an xsd documentation but I think the name explains pretty well.
>
> Also did you test the row-action part? (I did not)
>
>
>> action list in form inheritance
>> -------------------------------
>>
>>                  Key: OFBIZ-2889
>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-2889
>>              Project: OFBiz
>>           Issue Type: Improvement
>>             Reporter: Harmeet Bedi
>>             Assignee: Jacques Le Roux
>>              Fix For: SVN trunk
>>
>>          Attachments: 0FBIZ-4718.patch, ModelForm.java.diff, widget-form.xsd.diff
>>
>>
>> Purpose: make inheritance options more flexible and document them better for end user consumption.
>> Following XSD attributes
>> <xs:attribute name="extends-actions" default="override">
>> <xs:annotation>
>> <xs:documentation>If form derives from parent, form actions may
>>      override existing parent form actions, append to parent form actions or ignore
>>      parent form actions</xs:documentation>
>> </xs:annotation>
>> <xs:simpleType>
>> <xs:restriction base="xs:token">
>> <xs:enumeration value="append">
>> <xs:annotation>
>> <xs:documentation>append form actions to list of parent form actions</xs:documentation>
>> </xs:annotation>
>> </xs:enumeration>
>> <xs:enumeration value="prepend">
>> <xs:annotation>
>> <xs:documentation>prepend form actions to list of parent form actions</xs:documentation>
>> </xs:annotation>
>> </xs:enumeration>
>> <xs:enumeration value="override">
>> <xs:annotation>
>> <xs:documentation>If action block exists, ignore parent action list.
>>                            If action block does not exist use the parent action list
>> </xs:documentation>
>> </xs:annotation>
>> </xs:enumeration>
>> <xs:enumeration value="ignore">
>> <xs:annotation>
>> <xs:documentation>Ignore parent form actions.
>>                            Same as override with no actions specified in actions block.
>> </xs:documentation>
>> </xs:annotation>
>> </xs:enumeration>
>> </xs:restriction>
>> </xs:simpleType>
>> </xs:attribute>
>> same for
>> <xs:attribute name="extends-row-actions" default="override">
>> ....
>> </xs:attribute>
>> Attaching patches for xsd and ModelForm
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site : http://www.librenberry.net/