[jira] Closed: (OFBIZ-39) Format party address to show names, rather than IDs

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-39) Format party address to show names, rather than IDs

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-39?page=all ]

Si Chen closed OFBIZ-39.
------------------------

    Resolution: Fixed

I think it's fine to getRelated directly here, rather than create a Map in a beanshell script, put it into context, and then reference it again in FTL.  I committed in SVN r 423199.  Then I realized that it would cause an exception if for some reason abbreviation or geoName were not filled in (ie, null) and tested it by changing them in webtools's sql processor.  Sure enough it did.  So I made a changed version in SVN r 423200 which handled that.  I think this should be a good pattern to follow elsewhere.  Maybe we can even make this a reusable macro on other pages.

Thanks for sending it.

> Format party address to show names, rather than IDs
> ---------------------------------------------------
>
>                 Key: OFBIZ-39
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-39
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Andrew Yager
>            Priority: Minor
>         Attachments: partyAddress.diff
>
>
> This is a (probably poor) attempt to cause the party manager to display postal addresses by resolving the country and state id's. Changes along this line should probably happen in applications/party/webapp/partymgr/WEB-INF/actions/party/viewprofile.bsh, but that would involve double processing the postal address  list, so this should be faster. (but it does put some logic into the ftl file).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira