[jira] [Closed] (OFBIZ-3920) HtmlFormRenderer : with attribute skip-start, lookup fields are broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-3920) HtmlFormRenderer : with attribute skip-start, lookup fields are broken

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3920.
----------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch
                   13.07.02
                   12.04.06
                   14.12.01

OK, my last comment makes no sense, there is no skip-start on the FTL side!

Nevertheless I had a look at what it could entail regarding HtmlFormRenderer. he HtmlFormRenderer is no longer used to render lookup fields in forms widgets . It has been replaced by MacroFormRenderer class + htmlMenuMacroLibrary.ftl. Apart maybe indirectly in multi forms (renderMultiFormClose), but there are currently any lookups in a multi form, moreover one using skip-start!

So we can indeed safely close this issue as a duplicate of OFBIZ-6139.

In case of same issue elsewhere a new Jira should be created

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 14.12.01, 12.04.06, 13.07.02, Upcoming Branch
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)