[jira] [Closed] (OFBIZ-3961) Unnamed events in controller processor maps silently override each other

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-3961) Unnamed events in controller processor maps silently override each other

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-3961.
------------------------------------

    Resolution: Fixed

Scott fixed this in rev. 955882
I have back ported it to release09.04 in revision 1213627
               

> Unnamed events in controller processor maps silently override each other
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-3961
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3961
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 09.04, Release Branch 10.04
>            Reporter: Wickersheimer Jeremy
>             Fix For: Release Branch 09.04, Release Branch 10.04
>
>         Attachments: OFBIZ-3961.patch
>
>
> I found this issue while debugging our preprocessor events.
> Looks like a feature was introduced at some point to allow those events to override others with the same name (i guess in order to redefine the inherited events for a parent controller), but a side effect is that the previously defined events that worked without a name attribute are now overriding each other (as they are all events with the name Null).
> Worst thing is this happens kind of silently, so this is really not obvious. Instead i think the default should be to autogenerate a unique name if none is specified in the controller since overriding and event is something that should be done explicitly anyway.
> Attaching a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira