[jira] [Closed] (OFBIZ-5415) Invoice Item type drop down empty when creating new invoice item

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-5415) Invoice Item type drop down empty when creating new invoice item

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5415.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks for report Christian,

I committed a fix at r1547717

Rather than what you proposed, I used the same best practice than in r1527171

> Invoice Item type drop down empty when creating new invoice item
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-5415
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5415
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Christian Carlow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>
> The invoice item type drop down field is empty on the insert invoice item page.  The problem is that the EditInvoiceItem form in InvoiceForms.xml uses the list-name="invoiceItemTypes" which is never set.  
> Adding this to EditInvoiceItems in InvoiceScreens populates the drop down:
> <entity-condition entity-name="InvoiceItemType" list="invoiceItemTypes" />
> However, the description of the <list-options> is:
> description="${groovy:uiLabelMap.get('InvoiceItemType.description.'+invoiceItemTypeId)}
> And some of the Invoice Item types do not yet have a uiLabelMap value set for them so the uiLabelMap string is displayed instead.  This resolves the missing uiLabelMap problem:
> <list-options list-name="invoiceItemTypes" key-name="invoiceItemTypeId" description="${groovy: uiLabelString = 'InvoiceItemType.description.'+invoiceItemTypeId; uiLabelMapVal = uiLabelMap.get(uiLabelString); if(uiLabelMapVal != uiLabelString) return uiLabelMapVal; else return description;}"/>



--
This message was sent by Atlassian JIRA
(v6.1#6144)