[jira] [Closed] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5422.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 13.07
                   Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
         Assignee: Jacques Le Roux

Thanks Gareth,

Your patch is in
trunk r1550201
R13.07 r1550203
R12.04 r1550207 (done by hand)
R11.04 r1550210 (done by hand)

Not sure R11.04  was concerned but anyway can't hurt (the rounding built-ins exist since FreeMarker 2.3.13, all releases uses 2.3.19)



> htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5422
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5422
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: htmlFormMacroLibrary.patch
>
>
> There are 2 issues with the existing code.
> 1 - floor is applied to viewSize only not the computed value
> 2 - if the listSize divides with viewSize evenly, you'll get one extra
> eg
> 24/2=12 - no of pages = 13
> 24/5=4.8 - no of pages = 5



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)