[jira] Closed: (OFBIZ-612) Order Title i18n

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-612) Order Title i18n

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-612.
--------------------------------

    Resolution: Fixed

Thanks Guido Amarilla,

You patch is manually applied in trunk revision: 605347

> Order Title i18n
> ----------------
>
>                 Key: OFBIZ-612
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-612
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Assignee: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-612_v1.patch
>
>
> I´ve found some formatting and language errors when generating a Sales
> or Purchase Order PDF. I need to know if these are real errors and
> should be reported to a JIRA issue or should I customize it to my
> needs.
> Order Title in English: it is "Sales Order" but in spanish it is
> "Venta Orden" which is incorrect and should be "Orden de Venta". This
> is because it is being built using two strings: "Sales" + "Order" and
> that way of composing this phrase is language specific.
> The same happens in a purchase order: "Compra Orden" instead of "Orden
> de Compra"
> orderReportHeaderInfo.fo.ftl : line 24
> <fo:block number-columns-spanned="2"
> font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}
> ${uiLabelMap.OrderOrder}</fo:block>
> Solution:
> if it is changed to:
> <fo:block number-columns-spanned="2"
> font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}</fo:block>
> and   OrderEntityLabels.properties should be changed from this:
> OrderType.description.PURCHASE_ORDER=Purchase
> OrderType.description.SALES_ORDER=Sales
> to this
> OrderType.description.PURCHASE_ORDER=Purchase Order
> OrderType.description.SALES_ORDER=Sales Order
> (in every language's OrderEntityLabels_XX.properties files)
> This change would only affect Order list view. I tested it and it is
> not significative, except for the increased column width. The column
> "Order Type" uses "Purchase Order" and "Sales Order" for every item,
> instead of just "Purchase" or "Sales".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.