[jira] [Closed] (OFBIZ-7378) Enforce noninstantiability to InvoiceWorker Class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-7378) Enforce noninstantiability to InvoiceWorker Class

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar closed OFBIZ-7378.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1749891.

Thanks [~rishisolankii] and [~pratik.kulshreshth] for your contribution.

> Enforce noninstantiability to InvoiceWorker Class
> -------------------------------------------------
>
>                 Key: OFBIZ-7378
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7378
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7378.patch
>
>
> - Make InvoiceWorker class as final.
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
>     private static BigDecimal ZERO = BigDecimal.ZERO;
>     private static int decimals = UtilNumber.getBigDecimalScale("invoice.decimals");
>     private static int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
>     private static int taxDecimals = UtilNumber.getBigDecimalScale("salestax.calc.decimals");
>     private static int taxRounding = UtilNumber.getBigDecimalRoundingMode("salestax.rounding");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)