[jira] [Closed] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar closed OFBIZ-7589.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1751026.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to UtilHttp class
> --------------------------------------------
>
>                 Key: OFBIZ-7589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7589
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
>     public static final String MULTI_ROW_DELIMITER = "_o_";
>     public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
>     public static final String COMPOSITE_DELIMITER = "_c_";
>     public static final int MULTI_ROW_DELIMITER_LENGTH = MULTI_ROW_DELIMITER.length();
>     public static final int ROW_SUBMIT_PREFIX_LENGTH = ROW_SUBMIT_PREFIX.length();
>     public static final int COMPOSITE_DELIMITER_LENGTH = COMPOSITE_DELIMITER.length();
>     public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), and use them in following classes/scripts;
> {code}
>     GlEvents.java
>     ShoppingCartEvents.java
>     CheckAction.groovy
>     CheckRejected.groovy
>     ServiceMultiEventHandler.java
>     EbayEvents.java
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)