[jira] [Closed] (OFBIZ-8114) The "Only Not Used Labels" option of the Label Manager is broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-8114) The "Only Not Used Labels" option of the Label Manager is broken

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-8114.
----------------------------------
    Resolution: Fixed

At revision: 1759457  in trunk

I simply replaced the parenthesis in ServiceUtil.getResource() by 2 spaces when parsing files with getLabelsFromJavaFiles() and getLabelsFromFtlFiles().
ServiceUtil.getResource() breaks the parsing
Note: no occurrences of ServiceUtil.getResource() yet in FTL files, and only 16 in Java files.

I also replaced script by minilang in getLabelsFromSimpleMethodFiles()


I  had to use a getResourceRegex in a new webtools.properties files. This property
* Allow to remove this string from files when parsing with Label Manager, else it breaks
* Moreover the string can't be in the LabelReferences.java file, to avoid side effects

I have also increased the transaction-timeout of the screen "SearchLabels" to 600.
Because when using the "Only Not Used Labels" option the 1st pass can be long. 10 min should plenty enough, even on old machines. Not blocking anyway, just a bad stack trace in log

We have 5237 "Not Used Labels". I wondered if they were all real, I just checked some an indeed, they were not used.
But there are also a huge bunch of *.description.* labels which certainly make sense. I'll remove them from the "Only Not Used Labels" result in another Jira I'll create

I'll see if I can backport easily...



> The "Only Not Used Labels" option of the Label Manager is broken
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-8114
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8114
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Upcoming Branch
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Branch
>
>
> This is due to the introduction of ServiceUtil.getResource() at r1757979 for OFBIZ-7912



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)