[jira] [Closed] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin closed OFBIZ-8986.
--------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Release

It's ok for me Devanshu,
I commited your patch on trunk 1805956 and plugin trunk at 1805957
Thanks to Ankush Upadhyay and you for this

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-8986
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8986
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Ankush Upadhyay
>            Assignee: Ankush Upadhyay
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-8986.patch, OFBIZ-8986.patch, OFBIZ-8986_plugins.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout the application. The correct pattern to write is
> <make-value entity-name="ProductCategoryRole" value-field="newEntity"/>

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)