[
https://issues.apache.org/jira/browse/OFBIZ-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-9479.
--------------------------------------
Resolution: Fixed
Fix Version/s: Upcoming Release
Thanks Devanshu for the contribution.
Changes are committed in trunk at r1802673.
> Use FlexibleLocation.resolveLocation() instead of hard-coded path
> -----------------------------------------------------------------
>
> Key: OFBIZ-9479
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9479> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Devanshu Vyas
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9479.patch
>
>
> I found some occurrences where file path URL is prepared using the actual path of the file rather than the relative path. For e.g.
> {code}
> String imgPropertyFullPath = System.getProperty("ofbiz.home") + "/applications/product/config/ImageProperties.xml";
> {code}
> IMO the location URL of files should be prepared dynamically using relative paths and this can be achieved by using
> FlexibleLocation.resolveLocation() method. This method covers all the scenarios and in future, if we want to change anything, then all we need is to update the method and all instances will be fixed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
