[jira] [Closed] (OFBIZ-9711) [FB] Package org.apache.ofbiz.entity.cache

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-9711) [FB] Package org.apache.ofbiz.entity.cache

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-9711.
--------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Release

Thanks Dennis,

your patch is in trunk r1813631.


> [FB] Package org.apache.ofbiz.entity.cache
> ------------------------------------------
>
>                 Key: OFBIZ-9711
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9711
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9711_org.apache.ofbiz.entity.cache_bugfixes.patch
>
>
> - AbstractEntityConditionCache.java:68, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> RCN: Redundant nullcheck of model, which is known to be non-null in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.remove(GenericEntity)
> This method contains a redundant check of a known non-null value against the constant null.
> - AbstractEntityConditionCache.java:169, UCF_USELESS_CONTROL_FLOW
> UCF: Useless control flow in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(boolean, GenericEntity, GenericEntity)
> This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }
> - AbstractEntityConditionCache.java:183, UCF_USELESS_CONTROL_FLOW
> UCF: Useless control flow in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(String, boolean, List, List)
> This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)