[jira] [Closed] (OFBIZ-9804) Link in verification email for Newsletter gives security error

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-9804.
----------------------------------
    Fix Version/s: 18.12.01
                   17.12.01
       Resolution: Fixed

Fixed in
trunk 045f97b
R18 8a0ae589
R17 ff75d41c

I changed ContactListEmailTemplate.ftl to also use GET. Because we dont' want a form to ask, but only to hide parameters.

Handles the emails also in ecomseo after OFBIZ-11278

I have still to see why I get this message at the end of the process:
"Invalid verify code for the New Product Announcements"
ie when using the link in the last (3rd) email:
"Subscribe Contact List New Product Announcements"
This will be another Jira..!

> Link in verification email for Newsletter gives security error
> --------------------------------------------------------------
>
>                 Key: OFBIZ-9804
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9804
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ecommerce
>    Affects Versions: Trunk, Release Branch 16.11
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01, 18.12.01
>
>         Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter, provide email and click on subscribe button.(Here you should have email configuration to receive email)
> 3.  Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Found URL parameter [contactListId] passed to secure (https) request-map with uri [updateContactListPartyNoUserLogin] with an event that calls service [updateContactListPartyNoUserLogin]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010

--
This message was sent by Atlassian Jira
(v8.3.4#803005)