[jira] [Closed] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-9846.
----------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Branch

Thanks Aditya,

Great job, took me a moment to review :) Also because I had some still pending (unrelated) changes.

Your silghtly modifed patch is in trunk at revision: 1832307  

I simply removed from rainbowstone HtmlMenuMacroLibrary.ftl
        <#--<#if parameterList?has_content>-->
            <#--<#list parameterList as parameter>-->
                <#--<#local params += ",'${parameter.name}': '${parameter.value}'">-->
            <#--</#list>-->
        <#--</#if>-->
Not sure why you kept it, I guess it was forgotten after working on it, please check

> Replace Inline js with External js in renderFormClose macro
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9846
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9846
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-9846.patch
>
>

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)