[
https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327122#comment-16327122 ]
Jacques Le Roux edited comment on OFBIZ-10031 at 1/16/18 2:28 PM:
------------------------------------------------------------------
* didn’t convert the unnecessary services, as seen in this issue: OFBIZ-10146, maybe someone can have a look at that too
* Line 465: this seems like it was planned to be changed, maybe this is the right time to do that, since we’re already doing changes to this Service
* Couldn’t fully delete CatalogServices.xml, since one of its simple-methods (checkCategoryRelatedPermission) is used in another method in another .xml-file (/applications/commonext/minilang/setup/SetupEvents.xml). Unfortunately there is no service which defines this method, which means, that I cannot use a service instead.
* I tested all the services in this file as good as I could, they seem to work and do what they should do
I would appreciate if one of the involved people can give me a feedback on this file, thanks :)
was (Author: dennis balkir):
* didn’t convert the unnecessary services, as seen in this issue:
https://issues.apache.org/jira/browse/OFBIZ-10146, maybe someone can have a look at that too
* Line 465: this seems like it was planned to be changed, maybe this is the right time to do that, since we’re already doing changes to this Service
* Couldn’t fully delete CatalogServices.xml, since one of its simple-methods (checkCategoryRelatedPermission) is used in another method in another .xml-file (/applications/commonext/minilang/setup/SetupEvents.xml). Unfortunately there is no service which defines this method, which means, that I cannot use a service instead.
* I tested all the services in this file as good as I could, they seem to work and do what they should do
I would appreciate if one of the involved people can give me a feedback on this file, thanks :)
> Convert CategoryServices.xml mini lang to groovy
> ------------------------------------------------
>
> Key: OFBIZ-10031
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10031> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch
>
>
> Migration of the CategoryServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
