[jira] [Comment Edited] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560659#comment-16560659 ]

Suraj Khurana edited comment on OFBIZ-10398 at 7/28/18 12:32 PM:
-----------------------------------------------------------------

Committed on trunk at r#1836874 and related changes on plugins at r#1836895.


was (Author: suraj.khurana):
Committed at revision #1836874.

> Rename deletePartyContactMechPurpose* services
> ----------------------------------------------
>
>                 Key: OFBIZ-10398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10398
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, party
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10398-rename.patch, OFBIZ-10398.patch
>
>
> Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose are misnomers, as these functions don't delete records but expires those by setting the thruDate. The misnomers creates unnecessary confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)