[jira] [Comment Edited] (OFBIZ-10427) Add a mean to handle CSRF

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-10427) Add a mean to handle CSRF

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658930#comment-16658930 ]

Jacques Le Roux edited comment on OFBIZ-10427 at 10/22/18 2:36 PM:
-------------------------------------------------------------------

Hi Girish,

You mentionned "SameSite cookie" at https://markmail.org/message/lafktxeiedp5papb. I actually already gave it a try with OFBIZ-9865 but decided to revert because of side effects.

I'm not sure this will be needed once we will have a nonce associate with each request (I'm still working on it). Despite I want to note here that I put this comment then in r1812540
bq. // TODO maybe one day the ServletContext will allow to do that, then better in WebAppServletContextListener


was (Author: jacques.le.roux):
Hi Girish,

You mentionned "SameSite cookie" at https://markmail.org/message/lafktxeiedp5papb. I actually already gave it a try with OFBIZ-9865 but decide to to revert because of side effects.

I'm not sure this will be needed once we will have a nonce associate with each request (I'm still working on it). Despite I want to note here that I put this comment then in r1812540
bq. // TODO maybe one day the ServletContext will allow to do that, then better in WebAppServletContextListener

> Add a mean to handle CSRF
> -------------------------
>
>                 Key: OFBIZ-10427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10427
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: webtools_web.xml.patch
>
>
> I already worked on that in OFBiz but without success so far: https://markmail.org/message/r245yie623cdo3wz)
> The tracks I explored are:
> * https://www.owasp.org/index.php/Category:OWASP_CSRFGuard_Project (really not simple in OFBiz)
> * https://tomcat.apache.org/tomcat-8.5-doc/config/filter.html#CSRF_Prevention_Filter/Introduction (I think preferred)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)