[
https://issues.apache.org/jira/browse/OFBIZ-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690480#comment-16690480 ]
Jacques Le Roux edited comment on OFBIZ-10448 at 11/17/18 10:44 AM:
--------------------------------------------------------------------
Hi Mathieu,
We had [a discussion about that already|
https://markmail.org/message/mplvusuqn7oshl4v] ([started here|
https://markmail.org/message/pjf4uvgohd6a33in]). It ended with OFBIZ-10052.
IMO for the other debug levels it's unnecessary because they are defined in debug.properties as used (at least OOTB, and I'd not recommend false in production for them!). We have 934 "if (Debug." in code with among them 622 "if (Debug.ver". I'd be all for removing the 312 useless cases but not the "if (Debug.verboseOn())"
So, except if you have something more to say, please close this issue as "Won't fix", thanks
was (Author: jacques.le.roux):
Hi Mathieu,
We had [a discussion about that already|
https://markmail.org/message/mplvusuqn7oshl4v] ([started here|
https://markmail.org/message/pjf4uvgohd6a33in]). It ended with OFBIZ-10052.
IMO for the other debug levels it's unnecessary because they are defined in debug.properties as used (at least OOTB, and I'd not recommend false in production for them!). We have 934 "if (Debug." in code with among them 622 "if (Debug.ver". I'd be all for removing the 312 useless cases but not the "f (Debug.verboseOn())"
So, except if you have something more to say, please close this issue as "Won't fix", thanks
> Remove useless logging levels checks in ControlServlet
> ------------------------------------------------------
>
> Key: OFBIZ-10448
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10448> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10448_Improved-Remove-useless-logging-levels-checks.patch
>
>
> Those checks are already done inside the Debug module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
