[jira] [Comment Edited] (OFBIZ-10542) Instructions for Configurable PC don't work

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-10542) Instructions for Configurable PC don't work

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666084#comment-16666084 ]

Priya Sharma edited comment on OFBIZ-10542 at 10/27/18 1:21 PM:
----------------------------------------------------------------

Hi [~jacques.le.roux],
 * The method "showErrorAlert" populates the error section only when the message is not null and thus the button seems to be not working.
 * After a bit of exploration, I was able to figure out that if the instructions are null then this button should not be populated in the first place. But the check instructions?has_content failed and hence the button got populated. Thus adding an additional check for empty string would do.

Please provide your views so that I can proceed further.

Also, the inline js causes lots of errors on the browser console, should we add the meta tag in the header to allow inline-scripts

 

!console-error.png!


was (Author: priya.sharma.9362):
Hi [~jacques.le.roux],
 * The method "showErrorAlert" populates the error section only when the message is not null and thus the button seems to be not working.
 * After a bit of exploration, I was able to figure out that if the instructions are null then this button should not be populated in the first place. But the check instructions?has_content failed and hence the button got populated. Thus adding an additional check for null value would do.

Please provide your views so that I can proceed further.

Also, the inline js causes lots of errors on the browser console, should we add the meta tag in the header to allow inline-scripts

 

!console-error.png!

> Instructions for Configurable PC don't work
> -------------------------------------------
>
>                 Key: OFBIZ-10542
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10542
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Trunk, 16.11.04, Release Branch 17.12
>            Reporter: Jacques Le Roux
>            Assignee: Priya Sharma
>            Priority: Minor
>         Attachments: console-error.png
>
>
> This concerns only R16, R17 and the trunk. The "Instructions" button was not present in R13.
> This kind of message shows:
> Trunk:
> <a href="javascript:showErrorAlert('The following errors occurred','');" class="btn btn-outline-secondary btn-sm">Instructions</a>
> R16:
> <a href="javascript:showErrorAlert(" the="" following="" errors="" occurred","");"="" class="buttontext">Instructions</a>
> The same exists for all configurable products, notably Gold Pizza



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)