[
https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650215#comment-16650215 ]
Mathieu Lirzin edited comment on OFBIZ-10606 at 10/15/18 1:37 PM:
------------------------------------------------------------------
I have included [^OFBIZ-10606_0001-Add-WebAppCache.patch], [^OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch] , and [^OFBIZ-10606_0003-Refactor-WebAppCache.patch] which should be applied in order. The first patch extracts the code from {{ComponentConfig}} and adds some Javadoc. The second patch adds some tests for the new class. Finally the third one is doing some refactoring.
was (Author: mthl):
I have included [^OFBIZ-10606_0001-Add-WebAppCache.patch], [^OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch] , and [^OFBIZ-10606_0003-Refactor-WebAppCache.patch] which should be applied in order. The first patch extract the code from {{ComponentConfig}} and adds some Javadoc. The second patch adds some tests for this class. Finally the third one is for some refactoring.
> Webapp related code should be extracted from ‘ComponentConfig’
> ---------------------------------------------------------------
>
> Key: OFBIZ-10606
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10606> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch, OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch, OFBIZ-10606_0003-Refactor-WebAppCache.patch
>
>
> The {{ComponentConfig}} mixes various concerns which should be separated to make the code more understandable. The method touching the {{serverWebApps}} static member could be put in a separated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
