[
https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677975#comment-16677975 ]
Mathieu Lirzin edited comment on OFBIZ-10606 at 11/7/18 1:17 PM:
-----------------------------------------------------------------
Hello Jacques,
I have updated the patches by adding a test case covering the fix you made in OFBIZ-10637 (even if I am still confused by it) and refactoring the {{getWebappInfo}} method to return an {{Optional}}.
Additionally I think it is preferable when javadoc method comment refer only to their inputs (parameters, class members) and return value, but not to their callers. As a consequence I have adapted the Javadoc you wrote to follow this guideline (I have tried to follow the [Oracle Javadoc guidelines|
https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html])
Tell me if those changes are OK. I am currently trying to understand why the Rainbowstone theme does not use the {{LoginWorker#getAppBarWebInfos}} method.
was (Author: mthl):
Hello Jacques,
I have updated the patches by adding a test case covering the fix you made in OFBIZ-10637 (even if I am still confused by it) and refactoring the {{getWebappInfo}} method to return an {{Optional}}.
Additionally I think it is preferable when javadoc method comment refer only to their inputs (parameters, class members) and return value, but not to their callers. As a consequence I have adapted the Javadoc you wrote to follow this guideline (I have tried to follow the [[Oracle Javadoc guidelines|
https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html])
Tell me if those changes are OK. I am currently trying to understand why the Rainbowstone theme does not use the {{LoginWorker#getAppBarWebInfos}} method.
> Webapp related code should be extracted from ‘ComponentConfig’
> ---------------------------------------------------------------
>
> Key: OFBIZ-10606
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10606> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch, OFBIZ-10606_0001-Add-WebAppCache.patch, OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch, OFBIZ-10606_0003-Refactor-WebAppCache.patch, OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch, OFBIZ-10606_0005-Use-Optional-for-getWebappInfo.patch
>
>
> The {{ComponentConfig}} mixes various concerns which should be separated to make the code more understandable. The method touching the {{serverWebApps}} static member could be put in a separated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
