[jira] [Comment Edited] (OFBIZ-10639) Cookie Consent In E-Commerce

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862833#comment-16862833 ]

Jacques Le Roux edited comment on OFBIZ-10639 at 6/13/19 8:55 AM:
------------------------------------------------------------------

Hi,

That's right Aditya, It's MIT BTW. Also we should provide not only the minified library but also its plain source code version. I'm not sure it's for a legal reason, but it can help devs in case of issues.... Also trivial, are the changes in custom.css custom or copied from the ihavecookies project (example.css file)? If they are copied a simple line comment would be benefitial. And last but not least we prefer to generate our patches from root, easier for reviewers to apply and test ;)

About
bq. Apart from this, I am also in favor of keeping the name of the file init.js as it is. That will be helpful further for new custom code.
Could you explain please why init.js would be better than eg InitCookieConsent.js for new custom code? It's not clear to me and I would prefer the later.

This said good job Deepak, it works (but in IE11 for the policies text, but we should not care about it, IE 11 and Win 7 are soon dead) and it's simple :)

I think devs can easily adapt for their needs, so +1 from me with the questions and suggestions above resolved.


was (Author: jacques.le.roux):
Hi,

That's right Aditya, It's MIT BTW. Also we should provide not only the minified library but also its plain source code version. I'm not sure it's for a legal reason, but it can help devs in case of issues.... Also trivial, are the changes in custom.css custom or copied from the ihavecookies project (example.css file)? If they are copied a simple line comment would be benefitial. And last but not least we prefer to generate our patches from root, easier for reviewers to apply and test ;)

About
bq. Apart from this, I am also in favor of keeping the name of the file init.js as it is. That will be helpful further for new custom code.
Could you explain why init.js would be better than eg InitCookieConsent.js for new custom code. It's not clear to me and I would prefer the later.

This said good job Deepak, it works (but in IE11 for the policies text, but we should not care about it, IE 11 and Win 7 are soon dead) and it's simple :)

I think devs can easily adapt for their needs, so +1 from me with the questions and suggestions above resolved.

> Cookie Consent In E-Commerce
> ----------------------------
>
>                 Key: OFBIZ-10639
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10639
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: Trunk
>            Reporter: Deepak Nigam
>            Assignee: Swapnil M Mane
>            Priority: Minor
>         Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to get consent from visitors to store or retrieve any information on their computer, smartphone or tablet. It was designed to protect online privacy, by making consumers aware of how information about them is collected and used online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use cookies:
>  1. When someone visits your website, you need to let them know that your site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on their machine.
>  
>  For more information about EU cookie policy, please visit [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we should work towards its implementation. There are numerous open-source jQuery plugins available which we can use.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)