[jira] [Comment Edited] (OFBIZ-10692) Groovy DSL runService Exception Management

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737285#comment-16737285 ]

Leila Mekika edited comment on OFBIZ-10692 at 1/11/19 8:27 AM:
---------------------------------------------------------------

Hello [~jacques.le.roux],

Thanks for the test. I only think of compilation :) but i didn't check with the current trunk version.

For information, we also are adding an integration test to secure this improvement in case of a groovy lib update. We will add it to the patch when it will be ready

> Groovy DSL runService Exception Management
> ------------------------------------------
>
>                 Key: OFBIZ-10692
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10692
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Assignee: Gil Portenseigne
>            Priority: Minor
>              Labels: patch
>         Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread : [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>   
>  This ticket try to improve the way that errors are rendered when using {{run service}} groovy DSL method.
>  
>  To reproduce and test patch:
>  apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on createUomConversionDated service) and try to create a conversion rate with a fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>   
>  You should then see the following error:
>      The Following Errors Occurred: Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be same or smaller than from date)
>   
>  With  [^OFBIZ-10692.patch]  update, the error must be displayed like:
>      The Following Errors Occurred: Through date can't be same or smaller than from date
>   

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)