[
https://issues.apache.org/jira/browse/OFBIZ-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717158#comment-16717158 ]
Jacques Le Roux edited comment on OFBIZ-10701 at 12/11/18 1:50 PM:
-------------------------------------------------------------------
Thanks Mathieu,
Amazing work! It's almost perfect, I see only OFBIZ-6747 remaining.
Remeber you need to update your working copy before creating the patch ;) I got 3 rejected chuncks, 2 are only imports, the other is related with OFBIZ-10642. So I checked by hand and it's OK. Also remember we don't use tabs but spaces (found in build.gradle only).
Your patches are in trunk at revisions: 1848673+1848674
I was quite careful, but I hope nothing slipped in. I have too much things pending at the moment and I'm still not used to the new shelve svn feature (kind of Git stash).
was (Author: jacques.le.roux):
Thanks Mathieu,
Amazing work! It's almost perfect, I see only OFBIZ-6747 remaining.
Remeber you need to update your working copy before creating the patch ;) I got 3 rejected chuncks, 2 are only imports, the other is related with OFBIZ-10642. So I checked by hand and it's OK. Also remember we don't use tabs but spaces (found in build.gradle only).
Your patches are in trunk at revision: 1848673
I was quite careful, but I hope nothing slipped in. I have too much things pending at the moment and I'm still not used to the new shelve svn feature (kind of Git stash).
> Fix or Silence various warnings
> -------------------------------
>
> Key: OFBIZ-10701
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10701> Project: OFBiz
> Issue Type: Improvement
> Components: ALL PLUGINS, framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10701_Improved-Fix-or-Silence-various-warnings.patch, OFBIZ-10701_PLUGINS_Improved-Fix-various-warnings.patch
>
>
> In order to detect potential issues early, the linting compiler option should be used by default and disabled with {{./gradlew -PXlint:none build}}.
> Additionally it is important to reduce the number of warnings otherwise new warnings will remain unnoticed.
> The warning related to the {{com.googlecode.concurrentlinkedhashmap}} dependency should resolves itself once we handle upgrade to Caffeine like proposed in OFBIZ-6747.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
