[jira] [Comment Edited] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724248#comment-16724248 ]

Deepak Dixit edited comment on OFBIZ-10712 at 12/18/18 4:51 PM:
----------------------------------------------------------------

Thanks Jacques for review and suggestion,
This has been done at
ofbiz framework trunk at r#1849193
R17.12 framework at r#1849194
R16.11 at r#1849196


was (Author: deepak.dixit):
Thanks Jacques for review and suggestion,
This has been done at
ofbiz framework trunk at r#1849193
and R17.12 framework at r#1849194

> Inconsistent behaviour of ServiceDispatcher.checkAuth
> ------------------------------------------------------
>
>                 Key: OFBIZ-10712
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10712
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>            Priority: Major
>             Fix For: 16.11.06
>
>         Attachments: OFBIZ-10712.patch
>
>
> We have checkAuth method in service dispatcher class, this method performs multiple auth related check.
> if all checks passed it call the modelService.makeValid method to prepare service context (line#960) but this code executed only when service definition has a permission service call.
> If service does not have any permission service call then it does not call the modelService.makeValid and this may cause the service validation issue unknown parameter found.
> Ideally modelService.makeValid should call irrespective to permission service check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)