OFBiz › OFBiz - Notifications

[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 1 message Options
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773688#comment-16773688 ]

Jacques Le Roux edited comment on OFBIZ-10757 at 2/21/19 8:34 AM:
------------------------------------------------------------------

Here is the patch, After applying this patch will get 20 warning.
{code:java}
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy': class file for javax.annotation.concurrent.GuardedBy not found
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:44: warning: [deprecation] finalize() in Object has been deprecated
    protected void finalize() throws Throwable {
                   ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:48: warning: [deprecation] finalize() in Object has been deprecated
        super.finalize();
             ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java:142: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
    public static Map<String, String> getCertX500Map(javax.security.cert.X509Certificate cert) {
                                                                        ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SafeObjectInputStream.java:83: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated
            return Proxy.getProxyClass(classloader, cinterfaces);
                        ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:250: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
                        javax.security.cert.X509Certificate[] peerCerts;
                                           ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:252: warning: [deprecation] getPeerCertificateChain() in SSLSession has been deprecated
                            peerCerts = session.getPeerCertificateChain();
                                               ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:258: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
                        for (javax.security.cert.X509Certificate peerCert: peerCerts) {
                                                ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/AbstractCursorHandler.java:64: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated
        Class<?> proxyClass = Proxy.getProxyClass(loader, implClass);
                                   ^
20 warnings

> Task :test
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.16/aa30a6479a3f6efc2ba8cd810cc2caf22a613b19/groovy-all-2.4.16.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
{code}
 - We can update groovy to 2.5.6, this will fix the groovy warning related to finalize method, still will get the following warning,
GROOVY-8843
{code:java}
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 (file:/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy/2.5.6/6936e700f0fb1b50bac0698ada4347a769d40199/groovy-2.5.6.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.vmplugin.v7.Java7$1
{code}


was (Author: deepak.dixit):
Here is the patch, After applying this patch will get 20 warning.

{code}
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy': class file for javax.annotation.concurrent.GuardedBy not found
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:44: warning: [deprecation] finalize() in Object has been deprecated
    protected void finalize() throws Throwable {
                   ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:48: warning: [deprecation] finalize() in Object has been deprecated
        super.finalize();
             ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java:142: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
    public static Map<String, String> getCertX500Map(javax.security.cert.X509Certificate cert) {
                                                                        ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SafeObjectInputStream.java:83: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated
            return Proxy.getProxyClass(classloader, cinterfaces);
                        ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:250: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
                        javax.security.cert.X509Certificate[] peerCerts;
                                           ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:252: warning: [deprecation] getPeerCertificateChain() in SSLSession has been deprecated
                            peerCerts = session.getPeerCertificateChain();
                                               ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/SSLUtil.java:258: warning: [deprecation] X509Certificate in javax.security.cert has been deprecated
                        for (javax.security.cert.X509Certificate peerCert: peerCerts) {
                                                ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/AbstractCursorHandler.java:64: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated
        Class<?> proxyClass = Proxy.getProxyClass(loader, implClass);
                                   ^
20 warnings

> Task :test
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.16/aa30a6479a3f6efc2ba8cd810cc2caf22a613b19/groovy-all-2.4.16.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
{code}

- We can update groovy to 2.5.6, this will fix the groovy warning related to finalize method, still will get the following warning,
https://issues.apache.org/jira/browse/GROOVY-8843
{code}
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 (file:/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy/2.5.6/6936e700f0fb1b50bac0698ada4347a769d40199/groovy-2.5.6.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.vmplugin.v7.Java7$1
{code}

> Upgrade OFBiz to use Java JDK Version 11
> ----------------------------------------
>
>                 Key: OFBIZ-10757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10757
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Free forum by Nabble Edit this page