[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777817#comment-16777817 ]

Jacques Le Roux edited comment on OFBIZ-10757 at 2/27/19 9:14 AM:
------------------------------------------------------------------

I think bumping java to 11 should be done _after_ Deepak completes his prep work. His commit is more of a preparation for java 11, so perhaps it might be cleaner to avoid mixing concepts in one commit.

On the other hand, the patch looks much better. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose? 


was (Author: taher):
I think bumping java to 11 should be done _after_ Deepak completes his prep work. His commit is more of a preparation for java 11, so perhaps it might be cleaner to avoid mixing concepts in one commit.

On the other hand, the patch looks much better. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose?

 

 

 

> Upgrade OFBiz to use Java JDK Version 11
> ----------------------------------------
>
>                 Key: OFBIZ-10757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10757
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)