[
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779092#comment-16779092 ]
Jacques Le Roux edited comment on OFBIZ-10757 at 2/27/19 10:07 AM:
-------------------------------------------------------------------
Taher,
I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{CacheSoftReference::finalize}} it's actually also a warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the need of an InvocationHandler.
bq. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose?
I just tried to restrict to InvocationTargetException, but Eclipse (compliance 11, did not try to compile) does not agree and needs also those exceptions. We need to improve the Javadoc actually.
was (Author: jacques.le.roux):
Taher,
I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{ CacheSoftReference::finalize}} it's actually also a warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation] getProxyClass(ClassLoader,Class<?>...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the need of an InvocationHandler.
bq. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose?
I just tried to restrict to InvocationTargetException, but Eclipse (compliance 11, did not try to compile) does not agree and needs also those exceptions. We need to improve the Javadoc actually.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
