[jira] [Comment Edited] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753360#comment-16753360 ]

Mathieu Lirzin edited comment on OFBIZ-10817 at 1/27/19 11:32 AM:
------------------------------------------------------------------

Hello [~soledad],

I don't think silencing such template rendering errors with  "∎" is a good thing.  If the initial problem is that stacktraces pop up in production, then it is a bug and the developer is to blame.  If such mistakes appears frequently then this is probably a deeper technology issue meaning that templating in OFBiz is prone to error and should be improved or replaced.  If the latter is true then we should think how to design a more robust, simpler tool, not how to put dust under the carpet.


was (Author: mthl):
Hello [~soledad],

I don't think silencing such template rendering errors with  "∎" is a good thing.  If the initial problem is that stacktraces pop up in production, then the developer is to blame.  If such mistakes appears frequently then this is probably a deeper technology issue meaning that templating in OFBiz is prone to error and should be improved or replaced.  If the latter is true then we should think how to design a more robust, simpler tool, not how to put dust under the carpet.

> Configure stackTrace displaying on ftl rendering
> ------------------------------------------------
>
>                 Key: OFBIZ-10817
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10817
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property widget.verbose is true, no regression during development and when you switch to production site, in general your widget.verbose is false so end user haven't stack trace (that totally unused for them).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)