[jira] [Comment Edited] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837958#comment-16837958 ]

bd2019us edited comment on OFBIZ-10934 at 5/11/19 10:35 PM:
------------------------------------------------------------

[^affected_files][^OFBIZ10934-MORE.patch]

Attached are
 # A list of all files which have a likely applicable replaceAll() -> replace conversion followed by the line number
 # A diff of the patch applied to all affected_file items beginning with 'ofbiz/'

Some items are applicable to the ofbiz-framework and are not included in the sample patch. Though this may not comprehensively represent all the replaceAll() replace() in the code-base, these patches take care almost all instances that explicitly do not use a regex expression


was (Author: bd2019us):
[^affected_files][^OFBIZ10934-MORE.patch]

Attached are
 # A list of all files which have a likely applicable replaceAll() -> replace conversion
 # A diff of the patch applied to all affected_file items beginning with 'ofbiz/'

Some items are applicable to the ofbiz-framework and are not included in the sample patch. Though this may not comprehensively represent all the replaceAll() replace() in the code-base, these patches take care almost all instances that explicitly do not use a regex expression

> Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10934
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10934
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: bd2019us
>            Priority: Trivial
>              Labels: pull-request-available
>         Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files
>
>
> Affected files:
> # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> # framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> # framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
> # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java
> When replaceAll() is utilized and no regex is used, replaceAll() can be replaced with replace() for better performance.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)