[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045911#comment-17045911 ]
Pierre Smits edited comment on OFBIZ-11030 at 2/26/20 9:30 PM:
---------------------------------------------------------------
Thanks [~sberg],
I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Did you experience the same? Maybe you could have a look at this?
And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test)
With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date.
was (Author: pfm.smits):
Thanks [~sberg],
I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Maybe you could have a look at this?
And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test)
With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date.
> Convert FactServices.xml minilang to groovy
> -------------------------------------------
>
> Key: OFBIZ-11030
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11030> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Sebastian Berg
> Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-InventoryItemFact-DemoTrunk.png, OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-11030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.png, OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
