[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990785#comment-16990785 ]
Jacques Le Roux edited comment on OFBIZ-11304 at 12/8/19 10:15 AM:
-------------------------------------------------------------------
Hi Samuel,
I agree about running check also on releases branches. It's just that the Gradle check task is a new feature so it has not been backported on them. I don't see any issue doing so. We should discuss it on dev ML. Could you please start the discussion?
was (Author: jacques.le.roux):
Hi Samuel,
I agree about running check also on releases branches. It's just that the Gradle check task a new feature so it has not been backported on them. I don't see any issue about doing so. We should discuss it on dev ML.
> Install a Checkstyle pre-push on every committer machine
> --------------------------------------------------------
>
> Key: OFBIZ-11304
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11304> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago:
https://markmail.org/message/gkgmko4axj3vtnv3--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
