[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138097#comment-17138097 ]
Aditya Sharma edited comment on OFBIZ-11304 at 6/17/20, 4:51 AM:
-----------------------------------------------------------------
Hi Jacques,
I think we can also use GitHub actions with Gradle for the PR test, just like we are using for Sonarcloud.
Some quick links for the same:
1. [
https://github.com/marketplace/actions/setup-java-jdk]
2. [
https://github.com/apache/ofbiz-framework/actions/new]
3. [Setup link for OFBiz|
https://github.com/apache/ofbiz-framework/new/trunk?filename=.github%2Fworkflows%2Fgradle.yml&workflow_template=gradle]
This way all the PR needs to pass the checkstyle test before they are merged. Locally committers can use the pre-push hook.
>> What about checking branches? The hook is present in all branches but not checkstyle
I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process.
Wdyt?
was (Author: aditya.sharma):
Hi Jacques,
I think we can also use GitHub actions with Gradle for the PR test, just like we are using for Sonarcloud.
Some quick links for the same:
1. [
https://github.com/marketplace/actions/setup-java-jdk]
2. [
https://github.com/apache/ofbiz-framework/actions/new]
3. [Setup link|
https://github.com/apache/ofbiz-framework/new/trunk?filename=.github%2Fworkflows%2Fgradle.yml&workflow_template=gradle]
This way all the PR needs to pass the checkstyle test before they are merged. Locally committers can use the pre-push hook.
>> What about checking branches? The hook is present in all branches but not checkstyle
I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process.
Wdyt?
> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11304> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago:
https://markmail.org/message/gkgmko4axj3vtnv3--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
