[
https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110156#comment-17110156 ]
Jacques Le Roux edited comment on OFBIZ-11366 at 5/18/20, 11:26 AM:
--------------------------------------------------------------------
Hi Devanshu,
I wrote
bq. I agree for the new name.
But, after reviewing, the iteration in Minilang got my attention. It's better to keep the initial service name. Also, your did not test the service, right?
* Since you rightly used {{.queryList();}} (no fromDate passed) you should have assigned a List of GenericValue and iterated over, like in the minilang version
* then missed the imports of GenericValue, UtilDateTime and Timestamp.
* your line {{contentRole = from("ContentRole").where...}} was too long (max 120 chars as in Java)
was (Author: jacques.le.roux):
Hi Devanshu,
I wrote
bq. I agree for the new name.
But, after reviewing, the iteration in Minilang got my attention. It's better to keep the initial service name. Also, your did not test the service, right?
* Since you rightly used {{.queryList();}} (no fromDate passed) you should have assigned a List of GenericValue(*) and iterated over, like in the minilang version
* then missed the imports of GenericValue, UtilDateTime and Timestamp.
* your line {{contentRole = from("ContentRole").where...}} was too long (max 120 chars as in Java)
> Convert deactivateAllContentRoles service from mini-lang to groovy DSL
> ----------------------------------------------------------------------
>
> Key: OFBIZ-11366
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11366> Project: OFBiz
> Issue Type: Sub-task
> Components: content
> Affects Versions: Trunk
> Reporter: Devanshu Vyas
> Assignee: Devanshu Vyas
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11366.patch, OFBIZ-11366.patch
>
>
> Convert deactivateAllContentRoles service code from mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
