[jira] [Comment Edited] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042485#comment-17042485 ]

Priya Sharma edited comment on OFBIZ-11376 at 2/22/20 11:08 AM:
----------------------------------------------------------------

Hello Devanshu, 
 I have added the patch with the following changes
 * Added the groovy implementation for the service
 ** Added additional check to handle the duplicate content-id error, which was earlier not handled in the mini-lang service.
 * Updated the service definition
 * Removed the minilang version of the service

Please verify the patch and let me know in case some modifications are needed.

But I could not find any references for this service in the code base, i.e. this service has not been used anywhere, do we still want to keep it?


was (Author: priya.sharma.9362):
Hello Devanshu, 
 I have added the patch with the following changes
 * Added the groovy implementation for the service
 ** Added additional check to handle the duplicate content-id error, which was earlier not handled in the XML service.
 * Updated the service definition
 * Removed the minilang version of the service

Please verify the patch and let me know in case some modifications are needed.

But I could not find any references for this service in the code base, i.e. this service has not been used anywhere, do we still want to keep it?

> Convert createTopic service from mini-lang to groovy DSL
> --------------------------------------------------------
>
>                 Key: OFBIZ-11376
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11376
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Devanshu Vyas
>            Assignee: Priya Sharma
>            Priority: Minor
>         Attachments: OFBIZ-11376.patch
>
>
> Convert createTopic service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)