[jira] [Comment Edited] (OFBIZ-11381) Convert getDataResource service from mini-lang to groovy DSL

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042542#comment-17042542 ]

Pawan Verma edited comment on OFBIZ-11381 at 2/22/20 11:56 AM:
---------------------------------------------------------------

Hi [~kirti.arora],

Thanks, for the good work.

I see some of the code improvement in your patch:
 # We don't use a semicolon in groovy
 # Do we really need to define electronicText, imageDataResource
 # Can we write this line as:
{code:java}
result.electronicText = dataResource.getRelatedOne('ElectronicText', false)
{code}

Please let me your thoughts on this. Thanks!


was (Author: pawan.verma):
Hi [~kirti.arora],

Thanks, for the good work.

I see some of the code improvement in your patch:
 # We don't use semicolon(;) in groovy
 # Do we really need to define electronicText, imageDataResource
 # Can we write this line as:
{code:java}
// result.electronicText = dataResource.getRelatedOne('ElectronicText', false)
{code}

Please let me your thoughts on this. Thanks!

> Convert getDataResource service from mini-lang to groovy DSL
> ------------------------------------------------------------
>
>                 Key: OFBIZ-11381
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11381
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Devanshu Vyas
>            Assignee: Kirti Arora
>            Priority: Minor
>         Attachments: OFBIZ-11381.patch
>
>
> Convert getDataResource service code from mini-lang to groovy DSL.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)